setting extended_resource_collection to default true #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktmq
approved these changes
Nov 4, 2024
jvanbrie
commented
Nov 5, 2024
| - 'wafv2:GetLoggingConfiguration' | ||
| - 'wafv2:GetRegexPatternSet' | ||
| - 'wafv2:GetRuleGroup' | ||
| - 'wafv2:ListLoggingConfigurations' | ||
| - 'xray:BatchGetTraces' | ||
| - 'xray:GetTraceSummaries' | ||
| Metadata: |
There was a problem hiding this comment.
Sorted this list, and added new permissions.
ktmq
approved these changes
Nov 5, 2024
jvanbrie
deleted the
jon.vanbriesen/aws-quickstart-extended-resource-collection-default
branch
diogocp
reviewed
Nov 12, 2024
| CloudSecurityPostureManagementPermissions: | ||
| ResourceCollectionPermissions: |
There was a problem hiding this comment.
Renaming this parameter breaks main_extended.yaml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Changes 2 things:
I've also added a verification rule to ensure CSPM isn't set to True with ResourceCollection set to False. This is an invalid state.
Testing Guidelines
Ran taskcat, and ran it manually as well.