Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax: Update syntax for Style/SlicingWithRange #300

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

D-system
Copy link
Contributor

Changes proposed in this pull request:

  • Follow recommendation from StandardRb's Style/SlicingWithRange rule

@D-system D-system marked this pull request as draft November 23, 2024 12:08
@D-system
Copy link
Contributor Author

It brakes Ruby 2.5 compatibility. Let's keep this PR in draft until the next major release.

@D-system D-system changed the title Update syntax for Style/SlicingWithRange Syntax: Update syntax for Style/SlicingWithRange Nov 23, 2024
@Floppy
Copy link
Member

Floppy commented Nov 27, 2024

Oh, god, we can definitely drop Ruby 2.5 now. I'll look at updating the matrix for current versions only.

One nice thing about csvlint.io being reimplemented is that it no longer uses this gem (it's all in Node now apparently) so I don't need to worry about changes here breaking that site any more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants