Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the canserial query response #449

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Fix the canserial query response #449

merged 1 commit into from
Dec 3, 2024

Conversation

kageurufu
Copy link
Contributor

@kageurufu kageurufu commented Dec 3, 2024

I was accidentally sending the CanBoot/Katapult app_id 0x11 instead of the Danger app_id 0x07

Additionally, its Katapult now not CanBoot

Fixes #445

Checklist

  • pr title makes sense
  • squashed to 1 commit
  • added a test case if possible
  • if new feature, added to the readme
  • ci is happy and green

I was accidentally sending the CanBoot/Katapult app_id 0x11 instead of the
Danger app_id 0x07

Additionally, its Katapult now not CanBoot
@kageurufu kageurufu requested a review from a team as a code owner December 3, 2024 20:48
@rogerlz rogerlz merged commit 64eb1ee into master Dec 3, 2024
2 checks passed
@rogerlz rogerlz deleted the fix_canbus_query branch December 3, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug with canbus Query
2 participants