-
Notifications
You must be signed in to change notification settings - Fork 16
feat(endpoint): Support wp76xx based platforms #719
Conversation
Related #707 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before real implementation, we need the analysis for WP76xx enablement including the policy for maximize the reusable code. Update in #718 and then go back to this pull request.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you avoid copying from Sierra? That is, file "endpoint/endpointComp/interfaces.h"
22c46d4
to
684ccef
Compare
@@ -49,7 +49,12 @@ LEGATO_FLAGS += -DEP_TARGET=$(EP_TARGET) | |||
LEGATO_FLAGS := $(foreach flags, $(LEGATO_FLAGS), -C $(flags)) | |||
|
|||
# Include the build command from the specific target | |||
include endpoint/platform/$(EP_TARGET)/build.mk | |||
ifeq ($(EP_TARGET), simulator) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simplify the commands with
include endpoint/platform/$(EP_TARGET)/build.mk
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since you are going to replace HAL, you MUST explain and describe the transition. And even send another pull request(s).
|
||
static status_t simulator_get_key(uint8_t *key) { | ||
status_t get_device_key(uint8_t *key) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid exposing too many symbols.
This commit implement the WP76xx platform for the endpoint. [WIP] Connect success, Try to deploy on buildkite. Close DLTcollab#718
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Create a new pull request and corresponding issue which describe your plans on HAL rework.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Non-trivial changes should take place with diverse discussions!
This issue should not exist unless we have plans. |
This commit implement the WP76xx platform for the endpoint.
Close #718