Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable import_simulation to run without user-import when simulation exists #351

Conversation

qacwnfq
Copy link
Contributor

@qacwnfq qacwnfq commented Mar 25, 2024

Description

import_simulation command should run automatically and regularly.
For this reason, there should be a way to preemptively specify the user-input that might be required.

Related Issues

#349

Design Decisions

As simple as possible.

Performance & Quality

My editor added line breaks for lines that were too long.

Checklist

I, the author of this PR checked the following requirements for good software quality:

  • The code is properly formatted (I ran the formatter)

  • The code is written with our software quality standards (I ran the linter)

  • The code is written using our code style

  • Extensive in source documentation has been added

  • Unit and/or integration tests have been added

  • I tried addressing all new accessibility problems displayed in the console and documented if they can't be fixed

  • I attached performance measurements to prevent performance degradation

  • I added the changes to the next release section of the changelog

I, the reviewer checked the following things:

  • I ran the software once and tried all new and related functionality to this PR
  • I looked at all new and changed lines of code and commented on possible problems
  • I read the added documentation and checked if it is understandable and clear
  • I checked the added tests for completeness
  • I checked the internationalized strings for spelling errors
  • I checked the performance metrics for problems or unexplained degradation
  • I checked that the changes are noted in the changelog

@qacwnfq
Copy link
Contributor Author

qacwnfq commented Mar 25, 2024

@annawendler please review :)

@NXXR NXXR requested a review from annawendler March 26, 2024 09:15
@NXXR NXXR added class:enhancement New feature or request type:web-backend labels Mar 26, 2024
Copy link
Collaborator

@NXXR NXXR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not Anna but this looks good to me

@JonasGilg JonasGilg merged commit fb36b08 into DLR-SC:develop Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants