-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use cookie cloud for cookie #16851
base: master
Are you sure you want to change the base?
Conversation
}; | ||
|
||
const cookieDecrypt = (uuid: string, encrypted: string, password: string) => { | ||
const the_key = CryptoJS.MD5(`${uuid}-${password}`).toString().substring(0, 16); |
Check failure
Code scanning / CodeQL
Use of password hash with insufficient computational effort High
an access to COOKIE_CLOUD_PASSWORD
Password from
an access to password
Password from
an access to password
Password from
an access to password
Password from
an access to cookieCloudPassword
}; | ||
|
||
const cookieDecrypt = (uuid: string, encrypted: string, password: string) => { | ||
const the_key = CryptoJS.MD5(`${uuid}-${password}`).toString().substring(0, 16); |
Check failure
Code scanning / CodeQL
Use of a broken or weak cryptographic algorithm High
A broken or weak cryptographic algorithm
sensitive data from an access to COOKIE_CLOUD_UUID
A broken or weak cryptographic algorithm
sensitive data from an access to uuid
A broken or weak cryptographic algorithm
sensitive data from an access to uuid
A broken or weak cryptographic algorithm
sensitive data from an access to uuid
A broken or weak cryptographic algorithm
sensitive data from an access to cookieCloudUuid
Hi, @TonyRL. Could I kindly request your help in reviewing this PR? It utilizes CookieCloud to sync cookies from the user's browser, which would be beneficial for certain sites with short-lived cookies. Thank you! |
8ef9ae7
to
d224d67
Compare
Involved Issue / 该 PR 相关 Issue
Close #
Example for the Proposed Route(s) / 路由地址示例
New RSS Route Checklist / 新 RSS 路由检查表
Puppeteer
Note / 说明
增加从 CookieCloud 获取 Cookie 的能力,并为 javdb 添加了适配。
有个不确定是否合适的操作是在这里 lib/utils/cookie-cloud.ts#L25 使用了 globalThis,如果不使用 globalThis 的话在 lib/routes/javdb/utils.ts#L22 会获取不到内容,我不是一个专业的前端开发,实在不知道怎么办才用了 globalThis。如果大佬们能有更优雅的办法还请不吝赐教!