New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minor regressions in db_mysql and db_mysqli data wrappers #16

Open

AlexKlimenkov wants to merge 2 commits into DHTMLX:master from AlexKlimenkov:master

Contributor

AlexKlimenkov commented Jun 26, 2017

AlexKlimenkov@0247536 MySQLi wrapper must import MySQL wrapper explicitly since it's no longer included in db_common.php
how to reproduce the issue:

require_once('./connector-php/codebase/scheduler_connector.php');
require_once ("./connector-php/codebase/db_mysqli.php");

--> Fatal error:Class 'MySQLDBDataWrapper' not found in .../db_mysqli.php on line 8

AlexKlimenkov@cdf333f MySQL wrapper use classes defined in db_common.php but does not import them. It causes the error If db_mysql.php is included before connector. The error didn't happen in previous versions, other wrappers include db_common explicitly.
how to reproduce:

// include db_mysql.php before connector.php
require_once ('./connector-php-my/codebase/db_mysql.php'); 
require_once('./connector-php-my/codebase/scheduler_connector.php');

--> Fatal error: Class 'DBDataWrapper' not found in .../db_mysql.php

AlexKlimenkov added 2 commits

June 26, 2017 17:09


          [fix] db_mysqli.php adapter should import db_mysql.php


          [fix] db_mysql.php should import db_common.php explicitly

cdf333f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet