Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update references to original URL and fix API script bugs #1173

Merged
merged 5 commits into from
Nov 26, 2024

Conversation

JustinElms
Copy link
Contributor

@JustinElms JustinElms commented Nov 26, 2024

Background

There were still a number of references to the navigator.oceansdata.ca URL throughout the codebase and in the API script template. This PR removes those references so that data is annotated correctly and the API scripts point to the correct data source.

The API scripts also had a couple of other bugs that prevented the data from being fetched or saved properly which have now been addressed.

Checks

  • I ran unit tests.
  • I've tested the relevant changes from a user POV.
  • I've formatted my Python code using black ..

@JustinElms JustinElms changed the title Update references to original URL Update references to original URL and fix API script bugs Nov 26, 2024
@JustinElms JustinElms self-assigned this Nov 26, 2024
@JustinElms JustinElms added Bugfix A fix for something broken. Javascript Python Code Quality Anything related to the quality of the code labels Nov 26, 2024
@JustinElms JustinElms marked this pull request as ready for review November 26, 2024 19:28
@JustinElms JustinElms merged commit 1f7c5a1 into master Nov 26, 2024
6 checks passed
@JustinElms JustinElms deleted the update-url-references branch November 26, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bugfix A fix for something broken. Code Quality Anything related to the quality of the code Javascript Python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant