-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update MEI parsing and creation of OMR search tokens #845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dchiller
changed the title
Mei parsing updates
Update MEI parsing and creation of OMR search tokens
Apr 11, 2024
dchiller
requested review from
lucasmarchd01
and removed request for
lucasmarchd01
April 23, 2024 11:53
- change "s" (stay) to "r" (repeat) in ContourType - specify intervals as semitone intervals (to disambiguate other type of intervals that will be introduced later) - fix a number of comments that were missed in the neume_type -> neume_name transition - adjust tests of mei parser for various name changes
Fix neume_name type in Neume type Rename NeumeType to NeumeName
dchiller
force-pushed
the
mei-parsing-updates
branch
from
May 14, 2024 16:09
59eaed7
to
526011d
Compare
@lucasmarchd01 Could you give this another look? Thanks! |
lucasmarchd01
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a number of changes to
helpers/mei_processing/mei_parser.py
andhelpers/mei_processing/mei_tokenizer.py
and their associated type and test files. These changes include:MEITokenizer
so that we no longer return two different types of ngram documents (one on the neume level and one on the neume component level) but a single type of ngram document. This single type always includes pitch (and therefore contour and interval) information and will also include neume names if the ngram coincides with a set of complete neumes. This refactoring ensures that we can: 1. return pitch information when a neume name is queried; and 2. we don't have multiple ngrams (one containing pitch information and one containing neume names) for the same set of pitches.MEITokenizer
to include fields required for indexing (id
andtype
) and fields that we want to be easily available in the documents returned by Solr (manuscript
andfolio
)Additional refactoring includes:
neume_type
toneume_name
(andNeumeType
toNeumeName
, etc.)