Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick fix: Gottschalk reconstruction #821

Merged
merged 11 commits into from
Feb 1, 2024

Conversation

dchiller
Copy link
Collaborator

@dchiller dchiller commented Jan 26, 2024

This PR introduces an interim approach for serving a usable Gottschalk manuscript reconstruction on CU. In particular, it serve certain images of the manuscript and an IIIF manifest for the reconstruction on CU itself, allowing CU to work from edited versions of the manifest and images. Those edits include:

  • the addition of lacunae in the manifest (an image representing a lacuna is also added)
  • resizing of certain images that were well outside the norm of dimensions for images in the reconstruction
  • rotation of certain images so the top of the folio is at the top of the image

Closes #814 Closes #813 Closes #807

Anticipating that we will merge this PR, I've opened #822 to track the development of a longer-term, sustainable fix.

cantaloupe/Dockerfile Outdated Show resolved Hide resolved
Copy link

@jacobdgm jacobdgm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having walked through this with you, @dchiller, I'm confident that everything is here for a reason and makes sense. Would suggest tweaking the couple of things we made note of, but in general, this looks good.

@dchiller dchiller merged commit 6d6415b into DDMAL:main Feb 1, 2024
2 checks passed
@dchiller dchiller deleted the gottschalk-reconstruction branch February 1, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants