Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check whether MIDI.sources is undefined before disconnecting #790

Merged
merged 2 commits into from
Oct 12, 2023
Merged

Check whether MIDI.sources is undefined before disconnecting #790

merged 2 commits into from
Oct 12, 2023

Conversation

dchiller
Copy link
Collaborator

Closes #780

@dchiller dchiller marked this pull request as ready for review October 10, 2023 13:33
jacobdgm
jacobdgm approved these changes Oct 12, 2023
View reviewed changes
Copy link

@jacobdgm jacobdgm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine. Suggesting you increase the the indentation on the for block before merging. Approving.

@dchiller dchiller merged commit cff98f8 into DDMAL:main Oct 12, 2023
2 checks passed
@dchiller dchiller deleted the i-780-first-chant-play-fails branch October 12, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobdgm jacobdgm jacobdgm approved these changes

@lucasmarchd01 lucasmarchd01 Awaiting requested review from lucasmarchd01

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

After navigating to a manuscript, the first attempt to play audio fails. Subsequent attemps succeed.
2 participants
@dchiller @jacobdgm