Fuselage work on MinorFrames #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added __version__ to the package init instead of package main. Fixed the Fuselage.Cover.panel_flutter dynamic pressure. Pressures are provided in thousands of feet.
MinorFrame class created and outlined with the basic analysis methods.
Moved the material attribute to the base Component. Copied/modified the acoustic fatigue method from Cover for the MinorFrame. Added MinorFrame attributes and docstrings. Modified some docstrings to match Google styling. Will need to be more diligent with this in the future.
We go by Google standards now, boi!
Czarified
added
documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new Component:
MinorFrames.Added some initial attributes and methods for
MinorFramebut they are not analytically complete just yet.Fixed mypy errors, and updated all docstrings to match Google Python Style Guide.