Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

workspace: add/fix 1.83 lints #353

Merged
merged 5 commits into from
Nov 28, 2024
Merged

workspace: add/fix 1.83 lints #353

merged 5 commits into from
Nov 28, 2024

Conversation

hinto-janai
Copy link
Contributor

@hinto-janai hinto-janai commented Nov 28, 2024 •
edited
Loading

What

Adds/fixes lints from Rust 1.83.

Added clippy lints:

Added rustc lint group:

@github-actions github-actions bot added A-p2p Related to P2P. A-test-utils Related to test-utils. A-dependency Related to dependencies, or changes to a Cargo.{toml,lock} file. A-workspace Changes to a root workspace file or general repo file. A-consensus Related to consensus. A-storage Related to storage. A-net Related to networking. A-pruning Related to pruning. A-rpc Related to RPC. A-benches Related to benchmarks. A-binaries Related to binaries. labels Nov 28, 2024
hinto-janai
hinto-janai commented Nov 28, 2024
View reviewed changes
benches/criterion/cuprate-json-rpc/benches/response.rs Show resolved Hide resolved
consensus/context/src/difficulty.rs Outdated Show resolved Hide resolved
pruning/src/lib.rs Show resolved Hide resolved
storage/database/src/error.rs Show resolved Hide resolved
@hinto-janai hinto-janai marked this pull request as ready for review November 28, 2024 17:00
@Boog900 @hinto-janai
Update consensus/context/src/difficulty.rs
4e1d423 
Co-authored-by: hinto-janai <hinto.janai@protonmail.com>
@Boog900 Boog900 merged commit 38541db into Cuprate:main Nov 28, 2024
6 checks passed
@hinto-janai hinto-janai deleted the lint branch November 28, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Boog900 Boog900 Boog900 approved these changes

Assignees
No one assigned
Labels
A-benches Related to benchmarks. A-binaries Related to binaries. A-consensus Related to consensus. A-dependency Related to dependencies, or changes to a Cargo.{toml,lock} file. A-net Related to networking. A-p2p Related to P2P. A-pruning Related to pruning. A-rpc Related to RPC. A-storage Related to storage. A-test-utils Related to test-utils. A-workspace Changes to a root workspace file or general repo file.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hinto-janai @Boog900