Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Test the get_range function in
storage/database/src/backend/heed/database.rs
.Why
This is meant to address issue #348 .
Where
This is related to the heed database backend and related tests.
How
This PR is meant to address a perceived misunderstanding in issue #348 . The table insertions in the test have incrementing keys but all have a value equal to
0u64
.get_range
is defined to return Values rather than Keys, as per the function signature, yet in the reproduction code all the Values must equal 0.If we wish to test
get_range
we should be checking the Values within the new loop, as this is what get_range returns. I believe the functionality ofget_range
is correct.