DM 1876 opentelemetry custom exporter for platform used in eg ms #79
+161
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashhSAG93
commented
Mar 10, 2023
| import java.util.List; | ||
|
|
||
| @Component | ||
| public class GaugeStorage { |
There was a problem hiding this comment.
This component stores the list of gauge callbacks to be closed post export. See the comment mentioned in PR for the explanation
ashhSAG93
commented
Mar 10, 2023
| .gaugeBuilder("hwGaugeMetricStSt") | ||
| .buildWithCallback( | ||
| getObservableDoubleMeasurementConsumer(value, recordedTime)); | ||
| gaugeStorage.addObservableGauge(gauge); |
There was a problem hiding this comment.
Store the gauge in the list post instrumentation of metric
ashhSAG93
commented
Mar 10, 2023
| return "test"; | ||
| } | ||
|
|
||
| private Consumer<ObservableDoubleMeasurement> getObservableDoubleMeasurementConsumer(int value, DateTime recordedTime) { |
There was a problem hiding this comment.
Attributes used to record time at which the metric point was actually instrumented. Refer https://github.com/SoftwareAG/cumulocity-clients-java/pull/273/files#r1132329707 for explanation
ashhSAG93
commented
Mar 10, 2023
|
|
||
| @Override | ||
| public void onApplicationEvent(ExportCompletedEvent event) { | ||
| int metricCollectionSize = event.getMetricCollectionSize(); |
There was a problem hiding this comment.
Post export, close the list of gauges recorded.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR descibes how we can use the OpenTelemetry Exporter for Platform built in the PR DM-1876 OpenTelemetry PlatformMetricExporter, and some of the limitations with regards to OpenTelemetry Metrics instrumentation. The PR is in draft state and not to be reviewed