Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CTM-1130] implement workflow to create a GH release #11

Merged
merged 16 commits into from
Apr 26, 2024

Conversation

mvoigt-sag
Copy link
Collaborator

@mvoigt-sag mvoigt-sag commented Feb 20, 2024

@mvoigt-sag mvoigt-sag changed the title allow workflow_call [CTM-1130] implement workflow to create a GH release Feb 20, 2024
@joerghartmann
Copy link
Collaborator

joerghartmann commented Feb 20, 2024

Seems good to me.

-- should we also add the version info to the .aar file?

Yes.

-- should we also add the cumulocity-clients-kotlin-debug.aar?

No opinion on that one. Guess the release aar is enough?

@MarkJMReynolds-SAG
Copy link
Collaborator

Not an expert in the use of workflow_call, but seems about right to me.

@mvoigt-sag mvoigt-sag marked this pull request as ready for review February 22, 2024 07:38
@MarkJMReynolds-SAG
Copy link
Collaborator

MarkJMReynolds-SAG commented Apr 25, 2024

Update: Nope, ignore me, I figured it out.

finally it is working:

Looks mostly reasonable to me, but I suspect something is still not right - looking at the archived assets in the workflow -
- aar = 552k
- jar = 593k

Then in the release itself for build 269 -
- jar = 593k 🆗
- aar = 779 Bytes 😕

Maybe you really do mean this, in which case I'll approve, but I can't see intent for anything other than "pass the files along exactly as-created", in which case L62 in release.yml seems to be pointing at the wrong file, doesn't seem to match the change on L47 of build.yml IMO.

@mvoigt-sag mvoigt-sag merged commit b9e366d into main Apr 26, 2024
7 checks passed
@mvoigt-sag mvoigt-sag deleted the feature/CTM-1130-workflow-to-create-a-GH-release branch April 26, 2024 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants