Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace I18n ids with constants done #45

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Replace I18n ids with constants done #45

wants to merge 1 commit into from

Conversation

innodax
Copy link

@innodax innodax commented May 11, 2024 •
edited
Loading

Fixes #20

Hi, I found out that the following constants are repeated in several classes, would you like to pull all the constants into a separate class?

constant: TAB_WORKSPACE_TITLE
classes: CompaJApplication.java, WorkSpaceTab.java, WodgetTreeView.java

constant: TAB_TERMINAL_TITLE
classes: CompaJApplication.java, TerminalTab.java

@CrissNamon
Copy link
Owner

Hi. Thanks for the PR!
Yes, it would be nice to move these constants to separate class

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace I18n ids with constants
2 participants
@innodax @CrissNamon