Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CASMPET-6782 Add packages.internal #338

Closed
wants to merge 2 commits into from
Closed

CASMPET-6782 Add packages.internal #338

wants to merge 2 commits into from

Conversation

rustydb
Copy link
Contributor

@rustydb rustydb commented Sep 13, 2023

Summary and Scope

Issue Type

  • RFE Pull Request

Adds a packages.internal alias for pit.nmn.
This alias will work in conjunction with a new alias in unbound and powerDNS for handline .internal queries.
During bootstrap (PIT) this'll resolve to nexus, and once the PIT is gone it'll resolve to k8s nexus.

Prerequisites

  • I have included documentation in my PR (or it is not required)
  • I tested this on internal system (if yes, please include results or a description of the test)
  • I tested this on a vshasta system (if yes, please include results or a description of the test)

Idempotency

Risks and Mitigations

Adds a `packages.internal` alias for `pit.nmn`.
This alias will work in conjunction with a new alias in unbound and
powerDNS for handline .internal queries.
During bootstrap (PIT) this'll resolve to nexus, and once the PIT is
gone it'll resolve to k8s nexus.
@spillerc-hpe
Copy link
Contributor

I'm not willing to commit to providing this in PowerDNS yet, right now I have no way of creating or populating the .internal zone short of hacking it up manually.

@spillerc-hpe
Copy link
Contributor

This PR also doesn't cover the Unbound use case, the reservation needs to be added to SLS in order for unbound-manager to create a record.

https://github.com/Cray-HPE/cray-site-init/blob/main/pkg/csi/defaults.go#L418

@rustydb rustydb marked this pull request as draft September 13, 2023 17:33
@rustydb
Copy link
Contributor Author

rustydb commented Sep 13, 2023

This PR also doesn't cover the Unbound use case, the reservation needs to be added to SLS in order for unbound-manager to create a record.

https://github.com/Cray-HPE/cray-site-init/blob/main/pkg/csi/defaults.go#L418

Made into a draft, not trying to jump the gun here.

@rustydb
Copy link
Contributor Author

rustydb commented Sep 13, 2023

This PR also doesn't cover the Unbound use case, the reservation needs to be added to SLS in order for unbound-manager to create a record.

https://github.com/Cray-HPE/cray-site-init/blob/main/pkg/csi/defaults.go#L418

I can't add it there.

If I add it there, then it'll be in the same boat as packages.local, and on the PIT it'll resolve to 10.92.100.0/24.

@rustydb
Copy link
Contributor Author

rustydb commented Sep 14, 2023

After experimenting, it turns out that I can add packages.internal to both MTL.conf and statics.conf. The CNAME in MTL.conf takes precedence while DNSMasq is running, which means:

  • CSM can slurp up packages.internal from the api gw aliases line in statics.conf
  • packages.internal will resolve to the PIT nexus while the PIT is online, and then resolve to k8s-nexus once the PIT is gone

@rustydb rustydb marked this pull request as ready for review September 14, 2023 14:42
@rustydb
Copy link
Contributor Author

rustydb commented Sep 18, 2023

Closing in favor of a simpler solution via #339

@rustydb rustydb closed this Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants