Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] tweak functions for feedback widgets #402

Merged
merged 5 commits into from
Oct 14, 2024

Conversation

arifBurakDemiray
Copy link
Member

No description provided.

Copy link

github-actions bot commented Oct 10, 2024

Unit Test Results 🚀

658 tests  ±0   655 ✅  - 1   2m 42s ⏱️ -20s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     3 ❌ +1 

For more details on these failures, see this check.

Results for commit 55838f4. ± Comparison against base commit 1910cfd.

♻️ This comment has been updated with latest results.

sdk/src/main/java/ly/count/android/sdk/ModuleFeedback.java Outdated Show resolved Hide resolved
sdk/src/main/java/ly/count/android/sdk/ModuleFeedback.java Outdated Show resolved Hide resolved
CHANGELOG.md Outdated
@@ -1,3 +1,9 @@
## XX.XX.XX
* Added tweak functions to enhance the feedback module for more precise adjustments:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to clarify more

@turtledreams
Copy link
Contributor

how we will test this btw

@turtledreams turtledreams merged commit 14ca2d3 into staging Oct 14, 2024
2 of 5 checks passed
@turtledreams turtledreams deleted the widget_functions branch October 14, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants