Don't subscribe in AttestationTopicSubscriber if subscription is outdated #8837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolfyone
reviewed
Nov 19, 2024
| @@ -39,6 +40,7 @@ public class AttestationTopicSubscriber implements SlotEventsChannel { | |||
| private final Eth2P2PNetwork eth2P2PNetwork; | |||
| private final Spec spec; | |||
| private final SettableLabelledGauge subnetSubscriptionsGauge; | |||
| private final AtomicReference<UInt64> lastSlot = new AtomicReference<>(null); | |||
There was a problem hiding this comment.
this is probably better called currentSlot?
rolfyone
reviewed
Nov 19, 2024
| @@ -56,6 +58,14 @@ public synchronized void subscribeToCommitteeForAggregation( | |||
| aggregationSlot, UInt64.valueOf(committeeIndex), committeesAtSlot); | |||
| final UInt64 currentUnsubscriptionSlot = subnetIdToUnsubscribeSlot.getOrDefault(subnetId, ZERO); | |||
| final UInt64 unsubscribeSlot = currentUnsubscriptionSlot.max(aggregationSlot); | |||
| if (lastSlot.get() != null && unsubscribeSlot.isLessThan(lastSlot.get())) { | |||
There was a problem hiding this comment.
we should really read this once so that its not a concurrency issue
rolfyone
reviewed
Nov 19, 2024
Comment on lines
110
to
111
| if (lastSlot.get() != null | ||
| && subnetSubscription.unsubscriptionSlot().isLessThan(lastSlot.get())) { |
There was a problem hiding this comment.
same here, read lastSlot into a UInt64 in preference to this so that we can call get once
rolfyone
reviewed
Nov 20, 2024
| @@ -97,6 +107,15 @@ public synchronized void subscribeToPersistentSubnets( | |||
|
|
|||
| for (SubnetSubscription subnetSubscription : newSubscriptions) { | |||
| int subnetId = subnetSubscription.subnetId(); | |||
There was a problem hiding this comment.
surprising this doesnt need to be final...
|
Thank you for feedback, @rolfyone, updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we should do this check, especially as it could come from external validator and is not verified. Otherwise we subscribe for a slot and perform unsubscription on the next one.
PR Description
Fixed Issue(s)
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog