-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minimal single attestation #8676
Draft
tbenr
wants to merge
12
commits into
Consensys:master
Choose a base branch
from
tbenr:minimal-SingleAttestation
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbenr
force-pushed
the
minimal-SingleAttestation
branch
3 times, most recently
from
October 9, 2024 10:08
6c3c34e
to
4a4bef9
Compare
2 tasks
tbenr
force-pushed
the
minimal-SingleAttestation
branch
2 times, most recently
from
November 7, 2024 14:46
5690d77
to
20225aa
Compare
tbenr
force-pushed
the
minimal-SingleAttestation
branch
from
November 21, 2024 13:11
20225aa
to
c5e8836
Compare
tbenr
force-pushed
the
minimal-SingleAttestation
branch
from
November 22, 2024 13:27
c5e8836
to
0dac48b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This spike seems to work now.
It implements the minimal impact strategy, where we perform
SingleAttestation
<->Attestation
conversion to minimize changes.In particular:
SingleAttestation
schema when creates the electra single attestation topic handlerValidatableAttestation
:attestaiton
become modifiable (to cover the conversion transparently)SingleAttestation
version of the attestation (to be used when gossiping)SingleAttestation
, we:SingleAttestation
attestation toAttestation
and cache the original (happening insideValidatableAttestation
)IndexedAttestation
fromSingleAttestation
but I doubt it is usefulAttestation
produced locally, we:Attestation
attestation toSingleAttestation
(happening insideValidatableAttestation
)AttestationGossipManager
, when publishing unaggregated attestation we get it viavalidatableAttestation.getSingleAttestation()
which:Attestation
SingleAttestation
as result of the conversion happened during validation.ethereum/consensus-specs#3900
fixes #8804
Documentation
doc-change-required
label to this PR if updates are required.Changelog