Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: extract intensity components #244

Merged
merged 9 commits into from
Mar 23, 2021
Merged

feat: extract intensity components #244

merged 9 commits into from
Mar 23, 2021

Conversation

redeboer
Copy link
Member

Closes #184

@redeboer redeboer added this to the Release 0.2.1 milestone Mar 22, 2021
@redeboer redeboer requested a review from spflueger March 22, 2021 20:56
@redeboer redeboer self-assigned this Mar 22, 2021
@redeboer
Copy link
Member Author

redeboer commented Mar 22, 2021

@spflueger Currently, the functions are only implemented in usage/step3 notebook. We have to think where and how this can be integrated into the package.
https://pwa--244.org.readthedocs.build/projects/tensorwaves/en/244/usage/step3.html#intensity-components

@codecov
Copy link

codecov bot commented Mar 22, 2021

Codecov Report

Merging #244 (e08f084) into master (eba05ac) will decrease coverage by 0.49%.
The diff coverage is 64.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #244      +/-   ##
==========================================
- Coverage   79.31%   78.81%   -0.50%     
==========================================
  Files          12       13       +1     
  Lines         585      609      +24     
  Branches       79       89      +10     
==========================================
+ Hits          464      480      +16     
- Misses         90       95       +5     
- Partials       31       34       +3     
Flag Coverage Δ
unittests 78.81% <64.00%> (-0.50%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/tensorwaves/model.py 53.42% <50.00%> (+0.64%) ⬆️
src/tensorwaves/physics.py 65.21% <65.21%> (ø)

@redeboer redeboer marked this pull request as ready for review March 23, 2021 10:39
src/tensorwaves/model.py Show resolved Hide resolved
src/tensorwaves/model.py Outdated Show resolved Hide resolved
@redeboer redeboer merged commit 10ba92f into master Mar 23, 2021
@redeboer redeboer deleted the intensity-components branch March 23, 2021 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extract Intensity components from total intensity
2 participants