Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: download all files through gdown #4

Merged
merged 4 commits into from
Sep 8, 2023
Merged

ENH: download all files through gdown #4

merged 4 commits into from
Sep 8, 2023

Conversation

redeboer
Copy link
Member

@redeboer redeboer commented Sep 8, 2023 •
edited
Loading

  • All data files are now downloaded through gdown, including the ones that are hosted on Indico. In addition, the downloaded files are 'cached' so that they are not downloaded again when you rerun the notebook.
  • CI: notebooks that don't change are not rerun, because they are cached through jupyter-cache and the cache is shared through actions/cache.
  • The base environment now only installs packages that are required for Jupyter Lab and for building the documentation with Jupyter Book. Runtime dependencies like matplotlib are installed while running the notebooks. This decreases the size of the Docker container for Binder.

@redeboer redeboer added the 🖱️ DX Improvements to the Developer Experience label Sep 8, 2023
@redeboer redeboer self-assigned this Sep 8, 2023
@redeboer
Copy link
Member Author

redeboer commented Sep 8, 2023 •
edited
Loading

I'm considering to remove commit e7d71e0 that committed the files under data (they are removed in this PR) in order to decrease the size of this repository. Unfortunately, that would mean force pushing to the main branch.

--> Done ✔️

@redeboer redeboer marked this pull request as ready for review September 8, 2023 14:11
@redeboer redeboer enabled auto-merge (squash) September 8, 2023 14:11
@redeboer redeboer merged commit e3f0bb2 into ComPWA:main Sep 8, 2023
2 checks passed
@redeboer redeboer deleted the gdown branch September 9, 2023 18:06
redeboer added a commit to redeboer/strong2020-salamanca that referenced this pull request Sep 9, 2023
@redeboer
ENH: download all files through gdown (ComPWA#4)
e4efa3f 
* DX: add GitHub caching for data and notebooks
* MAINT: clean up more metadata
* MAINT: install runtime dependencies through notebooks
redeboer added a commit to redeboer/strong2020-salamanca that referenced this pull request Sep 9, 2023
@redeboer
ENH: download all files through gdown (ComPWA#4)
522a5e2 
* DX: add GitHub caching for data and notebooks
* DX: enable language navigation on Jupyter Lab
* MAINT: clean up more metadata
* MAINT: install runtime dependencies through notebooks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@redeboer redeboer

Labels
🖱️ DX Improvements to the Developer Experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@redeboer