Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slideshow: pause mode refresh #10607

Merged
merged 5 commits into from
Nov 27, 2024
Merged

Conversation

eszkadev
Copy link
Contributor

slideshow: refresh paused screen in Firefox

followup for commit b4decaee2bcd5f65a92ea887b9298968a9440db1
slideshow: show pause indicator in the in-window presentation

we detected that Firefox renders from time to time (around 1 / s)
the popup if main window is hidden - what doesn't happen in Chrome

slideshow: prevent Transition2d exception on program

this.program might be missing if using with hidden
main window browser tab

Transition2d.render (Transition2d.ts:153)
SlideChangeTemplate.SlideChangeBase.animate (SlideChangeBase.ts:82)
requestAnimationFrame
TransitionBase.startTransition (Transition2d.ts:36)
TransitionBase.start (Transition2d.ts:42)
SimpleActivity.startAnimation (SimpleActivity.ts:53)
ActivityBase.calcTimeLag (ActivityBase.ts:76)
SimpleContinuousActivityBase.calcTimeLag (SimpleContinuousActivityBase.ts:40)
ActivityQueue.process (ActivityQueue.ts:45)
SlideShowHandler.update (SlideShowHandler.ts:864)
SlideShowHandler.displaySlide (SlideShowHandler.ts:840)
(anonymous) (SlideShowNavigator.ts:265)

slideshow: remove inline style error

Content-Security-Policy: The page’s settings blocked an inline style (style-src-attr) from being applied because it violates the following directive: “style-src 'self'”

slideshow: make pause overlay text more visible

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Iab6ca4d4d104d3276a6ce0d0a87fb1d2de32984d
Content-Security-Policy: The page’s settings blocked an inline style (style-src-attr) from being applied because it violates the following directive: “style-src 'self'”

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Ic4fdfdab6ba8f7be2fba6f705947ea219993463a
this.program might be missing if using with hidden
main window browser tab

Transition2d.render (Transition2d.ts:153)
SlideChangeTemplate.SlideChangeBase.animate (SlideChangeBase.ts:82)
requestAnimationFrame
TransitionBase.startTransition (Transition2d.ts:36)
TransitionBase.start (Transition2d.ts:42)
SimpleActivity.startAnimation (SimpleActivity.ts:53)
ActivityBase.calcTimeLag (ActivityBase.ts:76)
SimpleContinuousActivityBase.calcTimeLag (SimpleContinuousActivityBase.ts:40)
ActivityQueue.process (ActivityQueue.ts:45)
SlideShowHandler.update (SlideShowHandler.ts:864)
SlideShowHandler.displaySlide (SlideShowHandler.ts:840)
(anonymous) (SlideShowNavigator.ts:265)

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I8a61a5bda68576dceb5dee2af44000031005bbbf
followup for commit b4decae
slideshow: show pause indicator in the in-window presentation

we detected that Firefox renders from time to time (around 1 / s)
the popup if main window is hidden - what doesn't happen in Chrome

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Id2ada402201deeb279421b7eb0746a41f81b8e5a
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Icb95e620055f17754f7895b42b8e8647282e06e8
Copy link
Contributor

@codewithvk codewithvk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything else looks good.

browser/src/slideshow/Transition2d.ts Show resolved Hide resolved
@eszkadev eszkadev merged commit b2a0139 into master Nov 27, 2024
13 checks passed
@eszkadev eszkadev deleted the private/eszkadev/slideshow-pause branch November 27, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants