Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slideshow: prevent slide sorter to receive key events on fullscreen mode #10605

Conversation

mcecchetti
Copy link
Contributor

Apart from changing the current slide in the editor,
this causes the onUpdateParts to be triggered which in turn request presentation
info again even if that's not needed.

Signed-off-by: Marco Cecchetti marco.cecchetti@collabora.com
Change-Id: I15efd3d205c7b03a76d04ff0e8f4f22b07bac00e

Copy link
Contributor

@eszkadev eszkadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok

@mcecchetti mcecchetti force-pushed the private/marco/slideshow-prevent-slidesorter-from-receive-key-event branch 2 times, most recently from 7ef980a to 825b14a Compare November 27, 2024 08:36
Apart from changing the current slide in the editor,
this causes the onUpdateParts to be triggered which in turn request presentation
info again even if that's not needed.

Signed-off-by: Marco Cecchetti <marco.cecchetti@collabora.com>
Change-Id: I15efd3d205c7b03a76d04ff0e8f4f22b07bac00e
@mcecchetti mcecchetti force-pushed the private/marco/slideshow-prevent-slidesorter-from-receive-key-event branch from 825b14a to d136dca Compare November 27, 2024 16:37
@mcecchetti mcecchetti merged commit 9a55269 into master Nov 27, 2024
13 checks passed
@mcecchetti mcecchetti deleted the private/marco/slideshow-prevent-slidesorter-from-receive-key-event branch November 27, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants