treeview: missing columns #10580
Merged
treeview: missing columns #10580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was a regression from commit aee68f7 browser: treeview: align listbox with headers using subgrid If we used autofilter in calc which has icons at the end of an entry, we got dummy column at the beginning of the row... This adds preprocessing of columns so we always have all of them unified (the same number of cols in every row) with dummy ones at the correct position. Exception is separator which has to be only one in the row to be full width. Signed-off-by: Szymon Kłos <szymon.klos@collabora.com> Change-Id: I8f3ed68100ca7f6b8c299e18e3867a4654d3a8c4
eszkadev
force-pushed
the
private/eszkadev/treeview-missing-columns
branch
from
f6cf1ed
to
ca430f3
Compare
|
passed but change id check didn't work |
Because we preprocess data to have all the entries with equal number of the columns already Signed-off-by: Szymon Kłos <szymon.klos@collabora.com> Change-Id: Icda50b2c378c1e39b3847bd18e58e35c2c0de015
eszkadev
force-pushed
the
private/eszkadev/treeview-missing-columns
branch
from
ca430f3
to
4a51dc3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jsdialog: treeview: put dummy columns at correct position