Remove duplicate sending of copy and cut commands. #10562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minion3665
requested changes
Nov 21, 2024
|
There is a duplicate call to cut command. There is also a tricky part for handling the command response. I will fix also that tricky code path. Thanks for checking. |
…false. Or we duplicate the command. Signed-off-by: Gökay Şatır <gokaysatir@collabora.com> Change-Id: Iefbb7c00a4806a3fd09b0ad4a8fa62e069ff9c80
Or it falls into catch block and disables the navigatorClipboardWrite. Signed-off-by: Gökay Şatır <gokaysatir@collabora.com> Change-Id: I9617ad2f28401f197ed7c32f4c0eeb1822d632ad
gokaysatir
force-pushed
the
private/gokay/cut-paste
branch
from
5cf9ed4
to
51bb918
Compare
Minion3665
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_doCopyCut function is already sending the relevant command.
Also saw that _sendCommandAndWaitForCompletion returns a promise that is not needed anymore (after Skyler's refactorings).
So we can remove that and use a boolean value for pursuing the state of cut/copy commands.
This fixes (Calc):
Change-Id: I0d4a2b0637892234a7dab68638f26cacadd8bb11
Summary
TODO
Checklist
make prettier-writeand formatted the code.make checkmake runand manually verified that everything looks okay