Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Private/timar/l10nfix #10545

Merged
merged 6 commits into from
Nov 21, 2024
Merged

Private/timar/l10nfix #10545

merged 6 commits into from
Nov 21, 2024

Conversation

timar
Copy link
Member

@timar timar commented Nov 20, 2024

  • Resolves: #
  • Target version: master

Summary

TODO

  • ...

Checklist

  • I have run make prettier-write and formatted the code.
  • All commits have Change-Id
  • I have run tests with make check
  • I have issued make run and manually verified that everything looks okay
  • Documentation (manuals or wiki) has been updated or is not required

Copy link
Contributor

@vmiklos vmiklos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK, see inline comment for a nit.

browser/src/layer/marker/TextInput.js Show resolved Hide resolved
browser/src/layer/marker/A11yTextInput.js Outdated Show resolved Hide resolved
browser/src/layer/marker/A11yTextInput.js Outdated Show resolved Hide resolved
@timar
Copy link
Member Author

timar commented Nov 20, 2024

the iOS CI failure is unrelated

browser/src/layer/marker/A11yTextInput.js Outdated Show resolved Hide resolved
browser/src/layer/marker/A11yTextInput.js Outdated Show resolved Hide resolved
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: Ic3bc6f808ab177fee11f3256b8c6d0093838cd3e
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I4e073fd249aa644177316624dd74d3ea369159d8
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I9ee5ddfd922c598ab8565d303d74979023e8be00
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I6f3bd499de38a53176da7730cdf6286b226c5bbc
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: Ic70d9ddeb79160e0a60054039e8f5b1317779f57
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: Ie030280dce10c0e71fd8664223b42857efd8fade
Copy link
Contributor

@thebearon thebearon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@timar timar merged commit efc1466 into master Nov 21, 2024
13 checks passed
@timar timar deleted the private/timar/l10nfix branch November 21, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants