-
Notifications
You must be signed in to change notification settings - Fork 710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Private/timar/l10nfix #10545
Merged
Merged
Private/timar/l10nfix #10545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timar
force-pushed
the
private/timar/l10nfix
branch
from
November 20, 2024 14:20
778602b
to
701f70c
Compare
vmiklos
approved these changes
Nov 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK, see inline comment for a nit.
thebearon
requested changes
Nov 20, 2024
timar
force-pushed
the
private/timar/l10nfix
branch
from
November 20, 2024 17:39
701f70c
to
3d86a6c
Compare
timar
force-pushed
the
private/timar/l10nfix
branch
from
November 20, 2024 18:49
3d86a6c
to
7cab8bc
Compare
the iOS CI failure is unrelated |
thebearon
requested changes
Nov 21, 2024
Signed-off-by: Andras Timar <andras.timar@collabora.com> Change-Id: Ic3bc6f808ab177fee11f3256b8c6d0093838cd3e
Signed-off-by: Andras Timar <andras.timar@collabora.com> Change-Id: I4e073fd249aa644177316624dd74d3ea369159d8
Signed-off-by: Andras Timar <andras.timar@collabora.com> Change-Id: I9ee5ddfd922c598ab8565d303d74979023e8be00
Signed-off-by: Andras Timar <andras.timar@collabora.com> Change-Id: I6f3bd499de38a53176da7730cdf6286b226c5bbc
Signed-off-by: Andras Timar <andras.timar@collabora.com> Change-Id: Ic70d9ddeb79160e0a60054039e8f5b1317779f57
Signed-off-by: Andras Timar <andras.timar@collabora.com> Change-Id: Ie030280dce10c0e71fd8664223b42857efd8fade
timar
force-pushed
the
private/timar/l10nfix
branch
from
November 21, 2024 06:27
7cab8bc
to
c1a7854
Compare
thebearon
approved these changes
Nov 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
TODO
Checklist
make prettier-write
and formatted the code.make check
make run
and manually verified that everything looks okay