Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slideshow: invalidate cached layers on slideshow restart #10542

Merged

Conversation

mcecchetti
Copy link
Contributor

Current slideshow implementation is not notified about presentation
modification. A complete solotion would require a good amount of work.
In the meanwhile we need a workround, which it's waht this patch provides.

Signed-off-by: Marco Cecchetti marco.cecchetti@collabora.com
Change-Id: I1ae3c09a60a1273dfe829f0932bd0fd83404de93

Current slideshow implementation is not notified about presentation
modification. A complete solution would require a good amount of work.
In the meanwhile we need a workround, which it's waht this patch provides.

Signed-off-by: Marco Cecchetti <marco.cecchetti@collabora.com>
Change-Id: I1ae3c09a60a1273dfe829f0932bd0fd83404de93
@mcecchetti mcecchetti force-pushed the private/marco/slideshow-invalidate-cache-on-restart branch from 3054c4b to b5a83ec Compare November 20, 2024 10:14
Copy link
Contributor

@eszkadev eszkadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will fix the problem with old content, but will introduce performance regression possibly

@mcecchetti mcecchetti merged commit 5918dff into master Nov 20, 2024
13 checks passed
@mcecchetti mcecchetti deleted the private/marco/slideshow-invalidate-cache-on-restart branch November 20, 2024 12:17
@mcecchetti
Copy link
Contributor Author

Thanks for your review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants