Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Draft] Enable nodePort specification on helm #10226

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cmassera
Copy link

Allow for nodePort specification for simple development setups without ingress controllers.

  • Resolves: #
  • Target version: master

Summary

This PR allows nodePort to be specified on helm chart values.yaml, allowing for simplified deployments on temporary bare metal setups. It removes the necessity of setting up an ingress controller, although it should not be used in production setups.

Checklist

  • I have run make prettier-write and formatted the code.
  • All commits have Change-Id
  • I have run tests with make check
  • I have issued make run and manually verified that everything looks okay
  • Documentation (manuals or wiki) has been updated or is not required

Allow for nodePort specification for simple development setups without ingress controllers.
Copy link

welcome bot commented Oct 14, 2024

Thanks for opening this pull request!

Things that will help get your PR across the finish line:

@pedropintosilva
Copy link
Contributor

Welcome to Collabora OnLine AKA COOL community :) and thanks for taking the time to contribute.

@pedropintosilva
Copy link
Contributor

I have add @timar as a reviewer. Please let us know once the PR is ready for review (as I see it's still a draft)

@eszkadev
Copy link
Contributor

@Rash419 what should we do with this PR?

@Darshan-upadhyay1110
Copy link
Contributor

thanks and welcome @cmassera ! do sign- off your commits and Add Change -id.

Sign-off

(DCO)

You should only do this if:

To add your Signed-off-by line to every commit in this branch:

Change-id

How to obtain Change-Id in commit message :

copy commit hook :
cp .git-hooks/commit-msg .git/hooks/commit-msg

And then amend your commit message :
git commit --amend
git push -f

Copy link
Contributor

@Rash419 Rash419 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested in minikube. Looks good! Also as @Darshan-upadhyay1110 pointed out signoff you commit, thanks : )

Minor nitpick if you can add comment block on how to use it in values.yaml below service block it would be great


# To quickly test without ingress controller you can make service type NodePort and pass a nodePort
# This should not be used in production
# service:
  # type: NodePort
  # nodePort: 30080

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: To Test
Development

Successfully merging this pull request may close these issues.

5 participants