-
Notifications
You must be signed in to change notification settings - Fork 710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Draft] Enable nodePort specification on helm #10226
base: master
Are you sure you want to change the base?
Conversation
Allow for nodePort specification for simple development setups without ingress controllers.
Thanks for opening this pull request! Things that will help get your PR across the finish line:
|
Welcome to Collabora OnLine AKA COOL community :) and thanks for taking the time to contribute. |
I have add @timar as a reviewer. Please let us know once the PR is ready for review (as I see it's still a draft) |
@Rash419 what should we do with this PR? |
thanks and welcome @cmassera ! do sign- off your commits and Add Change -id. Sign-off(DCO) You should only do this if: To add your Signed-off-by line to every commit in this branch:
Change-idHow to obtain Change-Id in commit message : copy commit hook : And then amend your commit message : |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested in minikube. Looks good! Also as @Darshan-upadhyay1110 pointed out signoff you commit, thanks : )
Minor nitpick if you can add comment block on how to use it in values.yaml below service block it would be great
# To quickly test without ingress controller you can make service type NodePort and pass a nodePort
# This should not be used in production
# service:
# type: NodePort
# nodePort: 30080
Allow for nodePort specification for simple development setups without ingress controllers.
Summary
This PR allows nodePort to be specified on helm chart values.yaml, allowing for simplified deployments on temporary bare metal setups. It removes the necessity of setting up an ingress controller, although it should not be used in production setups.
Checklist
make prettier-write
and formatted the code.make check
make run
and manually verified that everything looks okay