Merge pull request #361 from CoinFabrik/351-remove-zero_address-detector

Delete `zero-address` detector
CoinFabrik · Sep 9, 2024 · 1edbfb6 · 1edbfb6
2 parents b22bb9f + 9c109b9
commit 1edbfb6
Show file tree

Hide file tree

Showing 11 changed files with 1 addition and 591 deletions.
diff --git a/README.md b/README.md
@@ -61,10 +61,10 @@ Currently Scout includes the following detectors.
 | [dos-unexpected-revert-with-vector](https://github.com/CoinFabrik/scout-soroban/tree/main/detectors/dos-unexpected-revert-with-vector)                           | DoS due to improper storage. | [1](https://github.com/CoinFabrik/scout-soroban/tree/main/test-cases/dos-unexpected-revert-with-vector/dos-unexpected-revert-with-vector-1), [2](https://github.com/CoinFabrik/scout-soroban/tree/main/test-cases/dos-unexpected-revert-with-vector/dos-unexpected-revert-with-vector-2)            | Medium  |
 | [unrestricted-transfer-from](https://github.com/CoinFabrik/scout-soroban/tree/main/detectors/unrestricted-transfer-from)                           | Avoid passing an user-defined parameter as a `from` field in transfer-from. | [1](https://github.com/CoinFabrik/scout-soroban/tree/main/test-cases/unrestricted-transfer-from/unrestricted-transfer-from-1)                   | Critical  |
 | [unsafe-map-get](https://github.com/CoinFabrik/scout-soroban/tree/main/detectors/unsafe-map-get)                           | Inappropriate usage of the `get` method for `Map` in soroban | [1](https://github.com/CoinFabrik/scout-soroban/tree/main/test-cases/unsafe-map-get/unsafe-map-get-1)              | Medium |
-| [zero-or-test-address](https://github.com/CoinFabrik/scout-soroban/tree/main/detectors/zero-or-test-address)                           | Avoid zero or test address assignment to prevent contract control loss. | [1](https://github.com/CoinFabrik/scout-soroban/tree/main/test-cases/zero-or-test-address/zero-or-test-address-1)                   | Medium  |
 | [incorrect-exponentation](https://github.com/CoinFabrik/scout-soroban/tree/main/detectors/incorrect-exponentiation)                           | Warns against incorrect usage of ´^´.  | [1](https://github.com/CoinFabrik/scout-soroban/tree/main/test-cases/incorrect-exponentiation/incorrect-exponentiation-1)                   | Critical  |
 | [token-interface-events](https://github.com/CoinFabrik/scout-soroban/tree/main/detectors/token-interface-events)                           | Warns if any of the token functions does not emit an event.  | [1](https://github.com/CoinFabrik/scout-soroban/tree/main/test-cases/token-interface-events/token-interface-events-1)                   | Medium  |
 
+
 ## Output formats
 
 You can choose the output format that best suit your needs. Scout offers html, markdown, json, pdf and sarif reports. To specify the desired output run the following command:

diff --git a/detectors/zero-address/Cargo.toml b/detectors/zero-address/Cargo.toml
diff --git a/detectors/zero-address/src/lib.rs b/detectors/zero-address/src/lib.rs
diff --git a/.../detectors/21-incorrect-exponentiation.md → .../detectors/20-incorrect-exponentiation.md b/.../detectors/21-incorrect-exponentiation.md → .../detectors/20-incorrect-exponentiation.md
diff --git a/docs/docs/detectors/20-zero-or-test-address.md b/docs/docs/detectors/20-zero-or-test-address.md
diff --git a/...tors/22-integer-overflow -or-underflow.md → ...tors/21-integer-overflow -or-underflow.md b/...tors/22-integer-overflow -or-underflow.md → ...tors/21-integer-overflow -or-underflow.md
diff --git a/test-cases/zero-address/Cargo.toml b/test-cases/zero-address/Cargo.toml
diff --git a/test-cases/zero-address/zero-address-1/remediated-example/Cargo.toml b/test-cases/zero-address/zero-address-1/remediated-example/Cargo.toml