Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add JavaScript for Day 31 - Bubble Sort #376

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add JavaScript for Day 31 - Bubble Sort #376

wants to merge 3 commits into from

Conversation

RrennM
Copy link

@RrennM RrennM commented Oct 28, 2020 •
edited
Loading

Please make sure you have done the following:

  • Created a folder with the name of language you code inside directory for the day you are making the contribution to
  • Added the source code file inside /Day<n>/<Language>/
  • Tested your code
  • Added credits (author and date) at the top of the code
  • Updated README.md for /Day <n>/
  • Added yourself as a contributor using all-contributors-cli

aaditkamat
aaditkamat suggested changes Oct 31, 2020
View reviewed changes
Copy link
Contributor

@aaditkamat aaditkamat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You haven't run the npm run contributors:generate command mentioned in the Contributing Document.

aaditkamat
aaditkamat reviewed Oct 31, 2020
View reviewed changes
.all-contributorsrc Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaditkamat aaditkamat aaditkamat requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RrennM @aaditkamat