Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse conditionSet.MultipleConditionExplanation value #96

Merged
merged 23 commits into from
Mar 15, 2024

Conversation

northwestwitch
Copy link
Member

@northwestwitch northwestwitch commented Jan 31, 2024

This PR adds | fixes:

How to prepare for test:

  • Add an Explanation for multiple conditions column to the demo variant file

How to test:

  • Convert the files into json

Expected outcome:

  • The new field should be parsed

Review:

  • Code approved by
  • Tests executed by CR

This version is a:

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner

@northwestwitch northwestwitch changed the title Parse conditionSet.MultipleConditionExplanatio value Parse conditionSet.MultipleConditionExplanation value Jan 31, 2024
@northwestwitch
Copy link
Member Author

This is weird. I am having trouble validating the new field:

image

See csv file:

image

@codecov-commenter
Copy link

codecov-commenter commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.03%. Comparing base (846cec9) to head (fa36c85).
Report is 50 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #96      +/-   ##
==========================================
- Coverage   95.12%   95.03%   -0.10%     
==========================================
  Files          10       11       +1     
  Lines         431      463      +32     
==========================================
+ Hits          410      440      +30     
- Misses         21       23       +2     
Flag Coverage Δ
unittests 95.03% <100.00%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

northwestwitch and others added 19 commits February 9, 2024 08:07
Bumps [python-multipart](https://github.com/andrew-d/python-multipart) from 0.0.5 to 0.0.7.
- [Release notes](https://github.com/andrew-d/python-multipart/releases)
- [Changelog](https://github.com/Kludex/python-multipart/blob/master/CHANGELOG.md)
- [Commits](Kludex/python-multipart@0.0.5...0.0.7)

---
updated-dependencies:
- dependency-name: python-multipart
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [fastapi](https://github.com/tiangolo/fastapi) from 0.78.0 to 0.109.1.
- [Release notes](https://github.com/tiangolo/fastapi/releases)
- [Commits](fastapi/fastapi@0.78.0...0.109.1)

---
updated-dependencies:
- dependency-name: fastapi
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Remove silenced tests
@northwestwitch
Copy link
Member Author

Tested locally and it finally works. The new submission schema must have fixed the problem! 🥳

image

@northwestwitch northwestwitch merged commit c4abec1 into main Mar 15, 2024
7 checks passed
@northwestwitch northwestwitch deleted the multiple_conditions_explanation branch March 15, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parse and assign values to multipleConditionExplanation field
2 participants