New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix requests in proxy endpoints and parsing of observedIn #17

Merged

northwestwitch merged 1 commit into main from validate_endpoint

Jul 7, 2022

Member

northwestwitch commented Jul 7, 2022 •

edited

Loading

This PR adds | fixes:

Fixes parsing of csv files that was not capturing observedIn key/values (fix Missing observedIn key/value in demo submission #16)
Added the proxy endpoint to submission validate (fix New API endpoint in ClinVar to test submissions #12, fix Create an endpoint that accepts a json object containing raw submission data and returns a validated submission object #5)
Fixed proxy endpoint to submit the right request data

How to test:

GitHub actions test submission endpoints with no valid api key. Tests should pass
Manually test both proxy endpoints with a valid api key and the fixed sdemo ubmission object

Expected outcome:

Both endpoint should return success and a submission number (example SUB:XXXXXXX)

Review:

Tests executed by GitHub actions, CR

This version is a:

MAJOR - when you make incompatible API changes
MINOR - when you add functionality in a backwards compatible manner
PATCH - when you make backwards compatible bug fixes or documentation/instructions


          Fix requests in proxy endpoints and parsing of observedIn

29b8771

Member Author

northwestwitch commented Jul 7, 2022

Tested csv_2_json endpoint: 🆗

Tested validate endpoint 🆗

northwestwitch merged commit ddaad8c into main

northwestwitch deleted the validate_endpoint branch

July 8, 2022 07:18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet