Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

149 fix missing resistances #179

Merged
merged 3 commits into from
Aug 22, 2024
Merged

149 fix missing resistances #179

merged 3 commits into from
Aug 22, 2024

Conversation

samuell
Copy link
Contributor

@samuell samuell commented Aug 13, 2024

Description

Fixes #149 about missing OXA-48, sometimes being sometimes being reported as OXA-566 instead.

Primary function of PR

  • Hotfix
  • Patch
  • Minor functionality improvement
  • New type of analysis
  • Backward-breaking functionality improvement
  • This change requires internal documents to be updated
  • This change requires another repository to be updated

Testing

If the update is a hotfix, it is sufficient to rely on the development testing along with the Travis self-test automatically applied to the PR.

Test routine to verify the stability of the PR:

  • bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-microsalt-stage.sh BRANCHNAME
  • us
  • source activate S_microSALT
  • (SITUATIONAL) export MICROSALT_CONFIG=/home/proj/dropbox/microSALT.json
  • Select a relevant subset of the following:
  • microSALT analyse project MIC3109
  • microSALT analyse project MIC4107
  • microSALT analyse project MIC4109
  • microSALT analyse project ACC5551

Verify that the results for projects MIC3109, MIC4107, MIC4109 & ACC5551 are consistent with the results attached to AMSystem doc 1490, Microbial_WGS.xlsx

Test results

These are the results of the tests, and necessary conclusions, that prove the stability of the PR.

Sign-offs

@samuell samuell force-pushed the 149-fix-missing-resistances branch from bdf94c7 to 8bf9540 Compare August 14, 2024 07:26
@samuell samuell marked this pull request as ready for review August 16, 2024 11:37
@samuell samuell requested a review from a team as a code owner August 16, 2024 11:37
Copy link
Contributor

@karlnyr karlnyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments, nice 👍

tests/test_scraper.py Show resolved Hide resolved
tests/testdata/blast_single_resistance.txt Outdated Show resolved Hide resolved
@samuell samuell force-pushed the 149-fix-missing-resistances branch from 8bf9540 to c169d29 Compare August 22, 2024 10:59
@samuell samuell merged commit 1ab5a51 into rc400 Aug 22, 2024
1 check passed
@samuell samuell deleted the 149-fix-missing-resistances branch August 22, 2024 14:03
@karlnyr karlnyr linked an issue Oct 10, 2024 that may be closed by this pull request
@samuell
Copy link
Contributor Author

samuell commented Oct 10, 2024

Important clarification: This issue did not solve the reported missing VIM genes. See #180 for that one.

Initially we thought the fix would address both issues, but the VIM issue turned out to have different root cause, and was created as a separate issue #180

@samuell
Copy link
Contributor Author

samuell commented Oct 11, 2024

As can be seen here, OXA-48 turns up in the Typing report when run on MicroSALT 4.0.0, but did not before for the same sample, where instead OXA-566 showed up, for the same sample (Ending with A10), for case elegantflamingo.

MicroSALT 3.5.5, where you can see only OXA-566 being wrongly found:

image

MicroSALT 4.0.0, where you can see OXA-48 being correctly found:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with reporting resistance OXA-48
2 participants