Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created a new recipe #33

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Created a new recipe #33

wants to merge 1 commit into from

Conversation

susannemaner
Copy link

This PR adds | fixes:

How to prepare for test:

  • ssh to ...
  • Install on stage:
    bash servers/resources/SERVER.scilifelab.se/update-[THIS_TOOL]-stage.sh [THIS-BRANCH-NAME]

How to test:

Expected outcome:

  • [ ]

Review:

  • Code approved by
  • Tests executed by
  • "Merge and deploy" approved by

This version is a:

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

Copy link
Member

@northwestwitch northwestwitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, you are very close to making it work!
Check my comments!

@@ -0,0 +1,18 @@
Pastasallad

(../../img/gnocchi-pumpa.jpeg)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mmm this looks like the link to the picture of another recipe..

@@ -26,5 +26,6 @@ nav:
- Home: 'index.md'
- Pastas & similar:
- Gnocchi with Pumpkin: "main-courses/pastas/gnocchi_with_pumpkin.md"
- Pastasallad: "main-cources/pastaspastasallad.md"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you forget a / in this line? Looks like the recipe is not found:

image

@@ -0,0 +1,18 @@
Pastasallad
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here you created a file in the directory docs/main-courses/pastas/pasta/ . I think it's fine to have it a level above, that is docs/main-courses/pastas/.
This way the link to the specific recipe would be docs/main-courses/pastas/pastasallad.md

This way it would reflect what you added in the mkdocs.yml file!

@@ -26,5 +26,6 @@ nav:
- Home: 'index.md'
- Pastas & similar:
- Gnocchi with Pumpkin: "main-courses/pastas/gnocchi_with_pumpkin.md"
- Pastasallad: "main-cources/pastaspastasallad.md"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Pastasallad: "main-cources/pastaspastasallad.md"
- Pastasallad: "main-cources/pastas/pastasallad.md"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants