Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prettier #93

Merged
merged 7 commits into from
Oct 25, 2024
Merged

Prettier #93

merged 7 commits into from
Oct 25, 2024

Conversation

dnil
Copy link
Collaborator

@dnil dnil commented Oct 25, 2024

This PR adds a functionality or fixes a bug.

The linter also had a couple of things it couldn't fix on its own:

/Users/dannil/sandbox/gens/assets/js/fetch.js
  22:32  error  '_apiHost' is not defined  no-undef

/Users/dannil/sandbox/gens/assets/js/track/base.js
  227:24  error  'oc' is not defined  no-undef

/Users/dannil/sandbox/gens/assets/js/track/ideogram.js
    8:10  error  'thisExpression' is defined but never used                        no-unused-vars
   53:45  error  Array.prototype.map() expects a return value from arrow function  array-callback-return
  123:31  error  Array.prototype.map() expects a return value from arrow function  array-callback-return

/Users/dannil/sandbox/gens/assets/js/track/variant.js
  6:3  error  'isWithinElementBbox' is defined but never used  no-unused-vars

Eliminated them as I thought best, but pls check!

How to test:

  1. how to test it, possibly with real cases/data

Expected outcome:
The functionality should be working
Take a screenshot and attach or copy/paste the output.

Review:

  • code approved by

@coveralls
Copy link

coveralls commented Oct 25, 2024

Pull Request Test Coverage Report for Build 11520920744

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 20.331%

Totals Coverage Status
Change from base Build 10386790848: 0.0%
Covered Lines: 246
Relevant Lines: 1210

💛 - Coveralls

@dnil dnil marked this pull request as ready for review October 25, 2024 15:10
@dnil dnil merged commit d0c3ae4 into master Oct 25, 2024
7 checks passed
@dnil dnil deleted the prettier branch October 25, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants