Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify templates to submit form data without transforming it to json first #283

Merged
merged 10 commits into from
Apr 18, 2024

Conversation

northwestwitch
Copy link
Member

@northwestwitch northwestwitch commented Apr 17, 2024

This PR adds | fixes:

  • Since report endpoints are accepting form data, templates can submit forms without having to do the json transformation step now.

How to test:

  • Deploy on stage
  • Gp to demo report page, modify the query in "customize" and submit the form
  • Go to demo overview page and click on a different completeness tab

Expected outcome:

  • Report and overview pages should work

Review:

  • Code approved by HS
  • Tests executed by CR

This version is a:

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

@northwestwitch northwestwitch changed the title Change templates to submit form data without transforming it to json first Simplify templates to submit form data without transforming it to json first Apr 17, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.60%. Comparing base (2cc3fa4) to head (7ed34fb).
Report is 48 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #283      +/-   ##
==========================================
+ Coverage   94.54%   94.60%   +0.05%     
==========================================
  Files          35       35              
  Lines        1943     1982      +39     
==========================================
+ Hits         1837     1875      +38     
- Misses        106      107       +1     
Flag Coverage Δ
unittests 94.60% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Apr 17, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@northwestwitch
Copy link
Member Author

northwestwitch commented Apr 17, 2024

Test of report page

  • From demo report:
image
  • Change completeness cutoff and update values --> works! ✅
image

@northwestwitch
Copy link
Member Author

Test of genes coverage overview page

  • From demo overview page:
image
  • Change completeness tab --> works! ✅
image

@@ -46,19 +48,14 @@ <h2 class="accordion-header" id="flush-headingOne">

<div class="row">
<div class="col-7">
<label class="form-label">Included genes (Comma separated list of Ensembl IDs, HGNC IDs or HGNC symbols)</label>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Providing a list of genes as Ensembl IDs and HGNC symbols doesn't work yet, so it's safer to fix this label

@northwestwitch northwestwitch marked this pull request as ready for review April 17, 2024 12:32
Copy link
Contributor

@henrikstranneheim henrikstranneheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, 👍

@northwestwitch northwestwitch merged commit d7d322f into main Apr 18, 2024
7 checks passed
@northwestwitch northwestwitch deleted the update_report_ad_form branch April 19, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants