-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify templates to submit form data without transforming it to json first #283
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #283 +/- ##
==========================================
+ Coverage 94.54% 94.60% +0.05%
==========================================
Files 35 35
Lines 1943 1982 +39
==========================================
+ Hits 1837 1875 +38
- Misses 106 107 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Quality Gate passedIssues Measures |
@@ -46,19 +48,14 @@ <h2 class="accordion-header" id="flush-headingOne"> | |||
|
|||
<div class="row"> | |||
<div class="col-7"> | |||
<label class="form-label">Included genes (Comma separated list of Ensembl IDs, HGNC IDs or HGNC symbols)</label> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Providing a list of genes as Ensembl IDs and HGNC symbols doesn't work yet, so it's safer to fix this label
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, 👍
This PR adds | fixes:
How to test:
Expected outcome:
Review:
This version is a: