Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update library normalization script to work with the new Watchmaker LIMS workflow #533

Merged
merged 6 commits into from
Sep 25, 2024

Conversation

Karl-Svard
Copy link
Collaborator

Changed

  • Re-named pool-normalization EPP to library-normalization
  • Added new CLI flags for specifying UDF names in library-normalization

Steps to consider while deploying

  • Configuration changes:
  • Documentation updates:
  • Inform users by email:

Review:

  • Code approved by
  • Tests executed on stage by: (Document the test done with screen shots and description.)
  • "Merge and deploy" approved by

This version is a:

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

@Karl-Svard
Copy link
Collaborator Author

Karl-Svard commented Sep 25, 2024

Initial tests worked on stage on steps with the Total Volume udf on either the process or sample level:

lims -c <config> epps -l <log> -p <process> udf calculate library-normalization -sudf 'Sample Volume (ul)' -b 'Volume Buffer (ul)' --concentration-udf 'Concentration (nM)' --final-concentration-udf 'Final Concentration (nM)' --total-volume-udf 'Total Volume (uL)'

Screenshot 2024-09-25 at 15 52 12

lims -c <config> epps -l <log> -p <process> udf calculate library-normalization -sudf 'Sample Volume (ul)' -b 'Volume Buffer (ul)' --concentration-udf 'Concentration (nM)' --final-concentration-udf 'Final Concentration (nM)' --total-volume-pudf 'Total Volume (ul)'

Screenshot 2024-09-25 at 15 52 33

Copy link
Contributor

@idalindegaard idalindegaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Toppen!!

@Karl-Svard Karl-Svard merged commit a1dcfc3 into master Sep 25, 2024
2 checks passed
@Karl-Svard Karl-Svard deleted the watchmaker_normalization branch September 25, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants