Add linux plugin for nvidia-smi based checks #758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is stale because it has been open for 14 days with no activity and the Github Actions are not passing. |
github-actions
bot
added
Stale
|
Hi @mayrstefan , thank you for your contribution! Best |
mayrstefan
force-pushed
the
feature-nvidia-smi-linux-plugin
branch
from
7f9840e
to
f05ecb1
Compare
|
The test are still failing. This time the i18n tests fail |
|
You are right. |
|
Hi @mayrstefan, We have fixed the tests. There is nothing left on your side to do since the test failures were due to our system and not your changes. Best |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General information
Adds a check plugin for nvidia-smi for linux
Proposed changes
nvidia-smi on linux outputs the same information on linux. So the existing check for windows can be reused for linux. It is only necessary to add a plugin which outputs the same information. This PR adds the plugin for linux. My first attempts to add this to the agent were rejected (#680, #722)
I've also added a simple test which I wrote blind. If it does not work I need some guidance how to run those tests locally