This repository has been archived by the owner on Oct 25, 2022. It is now read-only.
Add ExtendedInteger types #224
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willemolding
requested review from
creativcoder,
noot,
hanabi1224 and
sudo-shashank
as code owners
hanabi1224
reviewed
May 5, 2022
| // #[test] | ||
| // /// Test both From impls to convert between the serialization/wire-type of a block and the internal representation | ||
| // /// The conversion must be lossless! | ||
| // fn roundtrip_serialization_types() { |
There was a problem hiding this comment.
Why is this test disabled?
willemolding
added
the
Do not merge
|
Since all the underlying serialization code has changed this PR is no longer relevent |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
Reference issue to close (if applicable)
Closes #206
Other information and links