Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verification + Payout benchmarks #476

Merged
merged 15 commits into from
Nov 18, 2024
Merged

Conversation

yahortsaryk
Copy link
Contributor

@yahortsaryk yahortsaryk commented Nov 13, 2024

Description

This PR introduces the following:

  • Benchmarking code for ddc-verification pallet
  • Weights for ddc-verification calculated on the reference machine
  • Incapsulation of ddc-payouts pallet logic as there is no external usages of the pallet
  • Deprecating unused AuthorisedCaller storage item and the migration for cleaning up
  • Renamings due to the tech debt

Breaking changes for the Subsquid indexer:

  • ClusterEraValidated event is renamed to ClusterEraPaid event
  • cluster.last_validated_era_id field is renamed to cluster.last_paid_era field
  • CustomerUsage type is renamed to BucketUsage type and moved to the primitives/src/lib.rs crate
  • NodeReward type is renamed to ProviderReward type and moved to the primitives/src/lib.rs crate
  • CustomerCharge type is moved to the primitives/src/lib.rs crate

Types of Changes

Please select the branch type you are merging and fill in the relevant template.

  • Hotfix
  • Release
  • Fix or Feature

Fix or Feature

Types of Changes

  • Tech Debt (Code improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Dependency upgrade (A change in substrate or any 3rd party crate version)

Migrations and Hooks

  • This change requires a runtime migration.
  • Modifies on_initialize
  • Modifies on_finalize

Checklist for Fix or Feature

  • Change has been tested locally.
  • Change adds / updates tests if applicable.
  • Changelog doc updated.
  • spec_version has been incremented.
  • network-relayer's events have been updated according to the blockchain events if applicable.
  • All CI checks have been passed successfully

Checklist for Hotfix

  • Change has been deployed to Testnet.
  • Change has been tested in Testnet.
  • Changelog has been updated.
  • Crate version has been updated.
  • spec_version has been incremented.
  • Transaction version has been updated if required.
  • Pull Request to dev has been created.
  • Pull Request to staging has been created.
  • network-relayer's events have been updated according to the blockchain events if applicable.
  • All CI checks have been passed successfully

Checklist for Release

  • Change has been deployed to Devnet.
  • Change has been tested in Devnet.
  • Change has been deployed to Qanet.
  • Change has been tested in Qanet.
  • Change has been deployed to Testnet.
  • Change has been tested in Testnet.
  • Changelog has been updated.
  • Crate version has been updated.
  • Spec version has been updated.
  • Transaction version has been updated if required.
  • All CI checks have been passed successfully

Copy link

gitguardian bot commented Nov 14, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
9100662 Triggered Generic High Entropy Secret a0328fc node/service/chain-specs/example.json View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@yahortsaryk yahortsaryk changed the title DAC + Payout benchmarks Verification + Payout benchmarks Nov 15, 2024
@yahortsaryk yahortsaryk marked this pull request as ready for review November 15, 2024 18:24
@auto-assign auto-assign bot requested a review from aie0 November 15, 2024 18:24
pallets/ddc-payouts/Cargo.toml Outdated Show resolved Hide resolved
pallets/ddc-payouts/src/migrations.rs Show resolved Hide resolved
pallets/ddc-clusters/src/lib.rs Show resolved Hide resolved
pallets/ddc-clusters/src/lib.rs Outdated Show resolved Hide resolved
pallets/ddc-customers/src/lib.rs Show resolved Hide resolved
pallets/ddc-customers/src/migration.rs Show resolved Hide resolved
pallets/ddc-verification/src/benchmarking.rs Show resolved Hide resolved
primitives/src/lib.rs Show resolved Hide resolved
pallets/ddc-payouts/src/lib.rs Show resolved Hide resolved
pallets/ddc-payouts/src/lib.rs Show resolved Hide resolved
@yahortsaryk yahortsaryk merged commit 20ee149 into dev Nov 18, 2024
5 checks passed
@yahortsaryk yahortsaryk deleted the feat/dac-payout-benchmarks branch November 18, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants