Footer #158
Open
Footer #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
misscs
commented
Jun 13, 2016
misscs
commented
- Prepare footer for international
- Improve/simplify markup
commit f3387cb Author: claudina sarahe <cs@misscs.me> Date: Mon Jun 13 04:59:03 2016 -0400 Make imports relative paths - Imports need to be defined relative to nightshade-core/src in order to avoid errors. This resolves errors when running storefront-static or nightshade commit a1737c2 Author: claudina sarahe <cs@misscs.me> Date: Mon Jun 13 04:57:50 2016 -0400 Add file comments
- Remove hard-coded content - Simplify html
| @@ -7,53 +7,42 @@ | |||
| {# | |||
| * Renders a standard or simplified footer | |||
| #} | |||
| {% macro footer(simple=false, class=null, id=null, phone_number='888–498–0003') %} | |||
| {% macro footer(data, simple=false, class=null, id=null) %} | |||
| <footer class="footer{% if simple %} footer--simple{% endif %}{% if class %} {{ class }}{% endif %}"{% if id %} id="{{ id }}"{% endif %}> | |||
| <div class="footer-top r-inner"> | |||
| {{ caller() }} | |||
| </div> | |||
| <div class="footer-bottom"> | |||
There was a problem hiding this comment.
What's a better class to replace footer-bottom? I like the feel of the the site- classes to describe the content, but it now feels disconnected from its parent class.
There was a problem hiding this comment.
I'm not a huge fan of class names that describe position, since the positions could theoretically be made incorrect in certain media queries via CSS. footer-bottom seems like navigation - could this be footer-nav?
|
@CasperSleep/frontier Left a couple comments looking for some input on class names. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.