Skip to content
This repository has been archived by the owner on Nov 22, 2022. It is now read-only.

Fix to Issue #18: ROG Armory changing config #27

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

LavaTiger99
Copy link
Contributor

Fix to Issue #18
Added an optional apply_plan() delay with variable in config. Updated instructions on dealing with ROG Armory issues

@CappyT
Copy link
Owner

CappyT commented Jul 8, 2020

Sorry, but this isn't really a fix. Merely a workaround (and a bad one). Waiting an arbitrary amount of time does not guarantee the profile won't be overridden.

The only solution I see is to just get rid of the ROG Armory service, at least while the app is running (disabling the windows service)
Also, I remember again that the usage of "time.sleep" renders the app unusable during that time because freezes the main thread.

@LavaTiger99
Copy link
Contributor Author

I wanted to give users the option, as noted in the instructions the second is a bad option and not recommended, and removing armory is preferred.

I will remove that option and just include the Removing armory instructions & reasoning.

@LavaTiger99
Copy link
Contributor Author

Updated to remove that delay option, now only includes instructions on removing armory crate.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants