Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build distribution and upload to PyPI #176

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

NoraLoose
Copy link
Contributor

This PR sets up a github workflow that builds C-Star locally, which creates distribution archives under the dist/ directory. These are the files that will be uploaded to PyPI when publishing a new release.

@dafyddstephenson
Copy link
Contributor

Thanks Nora! Are we able to test this before merging? I think #147 might be potentially problematic here

@NoraLoose
Copy link
Contributor Author

@dafyddstephenson definitely! The "Build distribution / test-built-dist" test that fails in the CI is that exact test. I think it fails for the same reason as #147.

@NoraLoose
Copy link
Contributor Author

Obviously we won't merge before this issue is resolved. :)

@dafyddstephenson
Copy link
Contributor

ah sorry, I'm debilitated by jetlag right now! I saw the workflow is only triggered on push to main and thought we'd have to merge to check it - didn't notice it was also on PR. I was hoping #168 might fix the static install issue as there's no longer a dynamically generated python file in the configuration, but no dice...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants