Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick fix in MATPOWER case reading #71

Merged
merged 2 commits into from
Mar 22, 2024
Merged

Quick fix in MATPOWER case reading #71

merged 2 commits into from
Mar 22, 2024

Conversation

jinningwang
Copy link
Member

@jinningwang jinningwang commented Mar 22, 2024

Add unit conversion into mpc2system branch part:
rate_a, rate_b, rate_c: MVA -> p.u.
amax, amin: degree -> rad

Copy link

codacy-production bot commented Mar 22, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.01% (target: -10.00%) 100.00% (target: 10.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (47e0798) 11438 5903 51.61%
Head commit (03880ef) 11441 (+3) 5906 (+3) 51.62% (+0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#71) 8 8 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.63%. Comparing base (47e0798) to head (03880ef).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #71      +/-   ##
===========================================
+ Coverage    78.62%   78.63%   +0.01%     
===========================================
  Files           58       58              
  Lines         4716     4719       +3     
===========================================
+ Hits          3708     3711       +3     
  Misses        1008     1008              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jinningwang jinningwang merged commit 8352e6c into develop Mar 22, 2024
24 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant