Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prep for patch release #58

Merged
merged 74 commits into from
Mar 4, 2024
Merged

Prep for patch release #58

merged 74 commits into from
Mar 4, 2024

Conversation

jinningwang
Copy link
Member

  • Add demo_AGC to demonstrate detailed SFR study
  • Add ExpressionCalc to handle post-solving calculation
  • Rename type='eq' to is_eq=False in Constraint to avoid overriding built-in attribute
  • Several formatting improvements

Copy link

codecov bot commented Mar 4, 2024

Codecov Report

Attention: Patch coverage is 88.11189% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 78.10%. Comparing base (61f7907) to head (7e2a68f).

Files Patch % Lines
ams/opt/omodel.py 80.48% 8 Missing ⚠️
ams/cli.py 0.00% 3 Missing ⚠️
ams/routines/dcopf.py 77.77% 2 Missing ⚠️
ams/system.py 0.00% 2 Missing ⚠️
ams/routines/dcpf.py 0.00% 1 Missing ⚠️
ams/routines/routine.py 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #58      +/-   ##
==========================================
+ Coverage   76.08%   78.10%   +2.02%     
==========================================
  Files          58       58              
  Lines        4754     4741      -13     
==========================================
+ Hits         3617     3703      +86     
+ Misses       1137     1038      -99     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codacy-production bot commented Mar 4, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-2.30% (target: -1.00%) 89.17%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (61f7907) 10810 5802 53.67%
Head commit (7e2a68f) 11444 (+634) 5879 (+77) 51.37% (-2.30%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#58) 157 140 89.17%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

Copy link
Member Author

@jinningwang jinningwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go.

@jinningwang jinningwang merged commit 960faaf into master Mar 4, 2024
33 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant