Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cheri-build] Add conditionals for building with CHERI. #1

Open
wants to merge 1 commit into
base: 10.4.132.20_cheri_codegen
Choose a base branch
from

Conversation

minglechen
Copy link

Adds missing ifdefs for not building with CHERI pure capability.

gcjenkinson pushed a commit that referenced this pull request May 2, 2024
Change-Id: I751a9898c2a31d73cb87b51480ca0ce7b24567fd
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4552978
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/11.5.150@{#1}
Cr-Branched-From: b71d303-refs/heads/main@{#87781}
gcjenkinson pushed a commit that referenced this pull request May 2, 2024
Change-Id: I57fb3b9bb4f3d2efed685294e652d791e34f700e
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4554879
Reviewed-by: Lutz Vahl <vahl@chromium.org>
Commit-Queue: Lutz Vahl <vahl@chromium.org>
Cr-Commit-Position: refs/branch-heads/11.5@{#1}
Cr-Branched-From: 0c4044b-refs/heads/11.5.150@{#1}
Cr-Branched-From: b71d303-refs/heads/main@{#87781}
gcjenkinson pushed a commit that referenced this pull request May 2, 2024
Revision: bf6aa50

BUG=v8:7700, chromium:1440723
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
R=verwaest@chromium.org

Change-Id: I8be744aa42858c23f5e38974328419468bebc7e7
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4556324
Reviewed-by: Toon Verwaest <verwaest@chromium.org>
Cr-Commit-Position: refs/branch-heads/11.5@{v8#2}
Cr-Branched-From: 0c4044b-refs/heads/11.5.150@{#1}
Cr-Branched-From: b71d303-refs/heads/main@{#87781}
gcjenkinson pushed a commit that referenced this pull request May 2, 2024
Change-Id: I727c736abfe78022270eebd9c49fb7942db5f3d4
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4556644
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/11.5@{v8#3}
Cr-Branched-From: 0c4044b-refs/heads/11.5.150@{#1}
Cr-Branched-From: b71d303-refs/heads/main@{#87781}
gcjenkinson pushed a commit that referenced this pull request May 2, 2024
... on non-JSReceiver objects.

Bug: chromium:1447430
(cherry picked from commit 515f187)

Change-Id: Ib260f028eece91135860d09871ee769b834cd53e
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4575070
Reviewed-by: Toon Verwaest <verwaest@chromium.org>
Commit-Queue: Igor Sheludko <ishell@chromium.org>
Cr-Commit-Position: refs/branch-heads/11.5@{v8#4}
Cr-Branched-From: 0c4044b-refs/heads/11.5.150@{#1}
Cr-Branched-From: b71d303-refs/heads/main@{#87781}
gcjenkinson pushed a commit that referenced this pull request May 2, 2024
Change-Id: I1c6b95059a0c04f136d4dcac59c77afff51c6899
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4579119
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/11.5@{v8#5}
Cr-Branched-From: 0c4044b-refs/heads/11.5.150@{#1}
Cr-Branched-From: b71d303-refs/heads/main@{#87781}
gcjenkinson pushed a commit that referenced this pull request May 2, 2024
Drive-by: fix printing of handlers in --trace-feedback-updates mode.

Bug: chromium:1450481
(cherry picked from commit e144f3b)

Change-Id: Ic8d20764a8eeac3d1f77c37cfb270d387482e7bb
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4584888
Reviewed-by: Toon Verwaest <verwaest@chromium.org>
Commit-Queue: Igor Sheludko <ishell@chromium.org>
Cr-Commit-Position: refs/branch-heads/11.5@{v8#6}
Cr-Branched-From: 0c4044b-refs/heads/11.5.150@{#1}
Cr-Branched-From: b71d303-refs/heads/main@{#87781}
gcjenkinson pushed a commit that referenced this pull request May 2, 2024
Change-Id: I2546f0bc04a9937a5887e62bd894fd98901e8b42
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4583273
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/11.5@{v8#7}
Cr-Branched-From: 0c4044b-refs/heads/11.5.150@{#1}
Cr-Branched-From: b71d303-refs/heads/main@{#87781}
gcjenkinson pushed a commit that referenced this pull request May 2, 2024
Fixed: chromium:1450114
(cherry picked from commit a7e2bef)

Change-Id: I2c692c385def56a2ee07e5ae902200249e00d470
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4604097
Reviewed-by: Igor Sheludko <ishell@chromium.org>
Cr-Commit-Position: refs/branch-heads/11.5@{v8#8}
Cr-Branched-From: 0c4044b-refs/heads/11.5.150@{#1}
Cr-Branched-From: b71d303-refs/heads/main@{#87781}
gcjenkinson pushed a commit that referenced this pull request May 2, 2024
Change-Id: I1cc8ff4bd7a6cc0df12c7a4f9e419c8a4c4fa5ef
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4605048
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/11.5@{v8#9}
Cr-Branched-From: 0c4044b-refs/heads/11.5.150@{#1}
Cr-Branched-From: b71d303-refs/heads/main@{#87781}
gcjenkinson pushed a commit that referenced this pull request May 2, 2024
Merged: [runtime] Create unoptimized data even if compilation is aborted
(cherry picked from commit 0e07abe)

Merged: [class] Export SharedFunctionInfo::CreateAndSetUncompiledData
(cherry picked from commit 1b55293)

Bug: chromium:1441254
Change-Id: I3c78d3972295c147d79d3734a4869c9b36f19433
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4603931
Auto-Submit: Igor Sheludko <ishell@chromium.org>
Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
Cr-Commit-Position: refs/branch-heads/11.5@{v8#10}
Cr-Branched-From: 0c4044b-refs/heads/11.5.150@{#1}
Cr-Branched-From: b71d303-refs/heads/main@{#87781}
gcjenkinson pushed a commit that referenced this pull request May 2, 2024
Change-Id: I1d0f6d6b797a20f6672a627c139bf6b3d242d4ef
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4605054
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/11.5@{v8#11}
Cr-Branched-From: 0c4044b-refs/heads/11.5.150@{#1}
Cr-Branched-From: b71d303-refs/heads/main@{#87781}
gcjenkinson pushed a commit that referenced this pull request May 2, 2024
The hole is not oddball anymore, but it should be still treated as essential object in the heap profiler.

(cherry picked from commit 24347db)

Bug: v8:14041, chromium:1453710
Change-Id: I867a12307163566d0eb646b16ba097839a4a313e
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4590820
Commit-Queue: Toon Verwaest <verwaest@chromium.org>
Reviewed-by: Toon Verwaest <verwaest@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#88088}
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4605000
Commit-Queue: Choongwoo Han <choongwoo.han@microsoft.com>
Cr-Commit-Position: refs/branch-heads/11.5@{v8#12}
Cr-Branched-From: 0c4044b-refs/heads/11.5.150@{#1}
Cr-Branched-From: b71d303-refs/heads/main@{#87781}
gcjenkinson pushed a commit that referenced this pull request May 2, 2024
Change-Id: I72414aee61936c56605d61949a5338590c4cad5a
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4604465
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/11.5@{v8#13}
Cr-Branched-From: 0c4044b-refs/heads/11.5.150@{#1}
Cr-Branched-From: b71d303-refs/heads/main@{#87781}
gcjenkinson pushed a commit that referenced this pull request May 2, 2024
This reverts commit 1f26e44.

Reason for revert: https://crbug.com/1453645#c12

Original change's description:
> [arm64][turbofan] Word[32|64]Select support
>
> Enable the use of csel.
>
> Change-Id: I6c2d3cc835149ce4beeb7334985ad2c11300d2c8
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4374179
> Reviewed-by: Thibaud Michaud <thibaudm@chromium.org>
> Commit-Queue: Martyn Capewell <martyn.capewell@arm.com>
> Reviewed-by: Andreas Haas <ahaas@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#87165}

(cherry picked from commit 51311a8)

Bug: chromium:1451929, chromium:1453645
Change-Id: I9b8a9c04b796a8459d3614eb5979e0ed99340ac8
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4607616
Commit-Queue: Adam Klein <adamk@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/11.5@{v8#14}
Cr-Branched-From: 0c4044b-refs/heads/11.5.150@{#1}
Cr-Branched-From: b71d303-refs/heads/main@{#87781}
gcjenkinson pushed a commit that referenced this pull request May 2, 2024
Change-Id: I57b3e40df00ed56c6640cda1a0b405c4f7ff3643
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4604845
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/11.5@{v8#15}
Cr-Branched-From: 0c4044b-refs/heads/11.5.150@{#1}
Cr-Branched-From: b71d303-refs/heads/main@{#87781}
gcjenkinson pushed a commit that referenced this pull request May 2, 2024
Merged: [interpreter] Don't number non-lexicals in TDZ elision
Revision: 260b62d

Merged: [interpreter] Refine hole check numbering for initialization
Revision: f72cbd5

Merged: [interpreter] Use |= in Variable::ForceHoleInitialization
Revision: dc628cc

Bug: chromium:1448545,chromium:1450771,v8:13723
Change-Id: Ie08b443061b48545bb65b3acbe4044fe604aaae8
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4610688
Commit-Queue: Shu-yu Guo <syg@chromium.org>
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Cr-Commit-Position: refs/branch-heads/11.5@{v8#16}
Cr-Branched-From: 0c4044b-refs/heads/11.5.150@{#1}
Cr-Branched-From: b71d303-refs/heads/main@{#87781}
gcjenkinson pushed a commit that referenced this pull request May 2, 2024
Change-Id: I9a0988746eece3de0d61a11699cd11a54d8ec8b1
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4614288
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/11.5@{v8#17}
Cr-Branched-From: 0c4044b-refs/heads/11.5.150@{#1}
Cr-Branched-From: b71d303-refs/heads/main@{#87781}
gcjenkinson pushed a commit that referenced this pull request May 2, 2024
...to avoid temporaries clobbering parameters.

Bug: v8:7700
(cherry picked from commit f7eda06b95654722f1b0720b9dfe0ff959564d71)

Change-Id: I92e1bbb91913d618bf66562ee79c8a5cc8d5c483
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4614667
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Reviewed-by: Victor Gomes <victorgomes@chromium.org>
Cr-Commit-Position: refs/branch-heads/11.5@{v8#18}
Cr-Branched-From: 0c4044b-refs/heads/11.5.150@{#1}
Cr-Branched-From: b71d303-refs/heads/main@{#87781}
gcjenkinson pushed a commit that referenced this pull request May 2, 2024
Change-Id: I71ca8c3424b1ae486f978d032d3c8794a3eae00b
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4622012
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/11.5@{v8#19}
Cr-Branched-From: 0c4044b-refs/heads/11.5.150@{#1}
Cr-Branched-From: b71d303-refs/heads/main@{#87781}
gcjenkinson pushed a commit that referenced this pull request May 2, 2024
Bug: chromium:1452137
(cherry picked from commit c7c4477)

Change-Id: I022863daf8da14feb68862b45bf3d3504a25540c
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4637890
Reviewed-by: Toon Verwaest <verwaest@chromium.org>
Auto-Submit: Igor Sheludko <ishell@chromium.org>
Commit-Queue: Toon Verwaest <verwaest@chromium.org>
Commit-Queue: Igor Sheludko <ishell@chromium.org>
Cr-Commit-Position: refs/branch-heads/11.5@{v8#20}
Cr-Branched-From: 0c4044b-refs/heads/11.5.150@{#1}
Cr-Branched-From: b71d303-refs/heads/main@{#87781}
gcjenkinson pushed a commit that referenced this pull request May 2, 2024
Change-Id: I6c85f519fd2970bd77861e5a6ee7ea0bedeb377c
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4640493
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/11.5@{v8#21}
Cr-Branched-From: 0c4044b-refs/heads/11.5.150@{#1}
Cr-Branched-From: b71d303-refs/heads/main@{#87781}
gcjenkinson pushed a commit that referenced this pull request May 2, 2024
Bug: chromium:1452137
(cherry picked from commit e548943)

Change-Id: I4be8b53f5668839515efefa566476d8e9c6182dd
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4637186
Auto-Submit: Tobias Tebbi <tebbi@chromium.org>
Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
Reviewed-by: Toon Verwaest <verwaest@chromium.org>
Commit-Queue: Toon Verwaest <verwaest@chromium.org>
Cr-Commit-Position: refs/branch-heads/11.5@{v8#22}
Cr-Branched-From: 0c4044b-refs/heads/11.5.150@{#1}
Cr-Branched-From: b71d303-refs/heads/main@{#87781}
gcjenkinson pushed a commit that referenced this pull request May 2, 2024
Change-Id: I9319549f0a04399a47efc3e24aa2bc91021a62e2
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4641731
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/11.5@{v8#23}
Cr-Branched-From: 0c4044b-refs/heads/11.5.150@{#1}
Cr-Branched-From: b71d303-refs/heads/main@{#87781}
gcjenkinson pushed a commit that referenced this pull request May 2, 2024
(cherry picked from commit 970eb92)

Bug: chromium:1455302
Change-Id: I9e90d7309f785f5a6672831a628394a155668bf8
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4614815
Reviewed-by: Liviu Rau <liviurau@google.com>
Auto-Submit: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Liviu Rau <liviurau@google.com>
Cr-Original-Commit-Position: refs/heads/main@{#88299}
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4645249
Cr-Commit-Position: refs/branch-heads/11.5@{v8#24}
Cr-Branched-From: 0c4044b-refs/heads/11.5.150@{#1}
Cr-Branched-From: b71d303-refs/heads/main@{#87781}
gcjenkinson pushed a commit that referenced this pull request May 2, 2024
(cherry picked from commit b04f0af)

Cq-Include-Trybots: luci.v8.try:v8_numfuzz_dbg
Cq-Include-Trybots: luci.v8.try:v8_numfuzz_rel
Cq-Include-Trybots: luci.v8.try:v8_numfuzz_tsan_rel
Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel
Cq-Include-Trybots: luci.v8.try:v8_linux64_msan_rel
Cq-Include-Trybots: luci.v8.try:v8_linux64_ubsan_rel
Bug: chromium:1448884
Change-Id: Ib3de10c84f82d838458b8dde8deab913161b4d59
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4568005
Reviewed-by: Liviu Rau <liviurau@google.com>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#87874}
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4645251
Auto-Submit: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Liviu Rau <liviurau@google.com>
Cr-Commit-Position: refs/branch-heads/11.5@{v8#25}
Cr-Branched-From: 0c4044b-refs/heads/11.5.150@{#1}
Cr-Branched-From: b71d303-refs/heads/main@{#87781}
gcjenkinson pushed a commit that referenced this pull request May 2, 2024
Change-Id: I04ac502115dd997e13f3450e117758e9be3d219b
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4644755
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/11.5@{v8#26}
Cr-Branched-From: 0c4044b-refs/heads/11.5.150@{#1}
Cr-Branched-From: b71d303-refs/heads/main@{#87781}
gcjenkinson pushed a commit that referenced this pull request May 2, 2024
The CL caused a spike of crashes with the signature:
GlobalHandlesWeakRootsUpdatingVisitor::UpdatePointer()

Revert this temporarily to unblock Beta.

(cherry picked from commit 629368a)
(cherry picked from commit 7b650dab3643292bd27ad423d228b7cae9b7fc2e)

Bug: chromium:1441372
Change-Id: I98982ed84c40b76c5386f1f779f009f247ffa88f
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4589073
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Commit-Queue: Anton Bikineev <bikineev@chromium.org>
Auto-Submit: Anton Bikineev <bikineev@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#88062}
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4589075
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4660512
Commit-Queue: Lutz Vahl <vahl@chromium.org>
Reviewed-by: Lutz Vahl <vahl@chromium.org>
Cr-Commit-Position: refs/branch-heads/11.5@{v8#27}
Cr-Branched-From: 0c4044b-refs/heads/11.5.150@{#1}
Cr-Branched-From: b71d303-refs/heads/main@{#87781}
gcjenkinson pushed a commit that referenced this pull request May 2, 2024
Change-Id: I5377874ba5e7921247f08eb5b6739c4a5c9f70d8
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4661863
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/11.5@{v8#28}
Cr-Branched-From: 0c4044b-refs/heads/11.5.150@{#1}
Cr-Branched-From: b71d303-refs/heads/main@{#87781}
gcjenkinson pushed a commit that referenced this pull request May 2, 2024
… tracking

Here are the steps that lead to the bug:
  - main thread: map `a` was being slack-tracked
  - background: a compilation job serializes `a` into a MapRef `aRef`
  - main thread: slack tracking finished for this map.
  - main thread: a store to an object of map `a` created a transition
    from map `a` to map `b`, and the property stored was stored as the
    1st item of the out-of-object properties.
  - background: compilation reached JSNativeContextSpecialization,
    which tried to optimize a JSSetNamedProperty (specifically, the
    same operation that lead to the map transition on the main
    thread). There was no feedback for this operation since it hadn't
    been executed before (otherwise, the map transition would have had
    happened before, and the MapRef would not have been out of date).
    JSNativeCtxtSpec inferred maps of the receiver from previous
    CheckMaps, and realized that the store was transitioning (from `a`
    to `b`). It looked at the MapRef `aRef` to see how much unused
    properties the object had. `aRef` still had the cached
    slack-tracking data, and thus thought that it still had unused
    properties, whereas in reality, `a` didn't have any left, and a
    new property backing store should have been allocated.
  - main thread: when executing the store generated, we tried to write
    to the 1st item of the out-of-object properties of an object
    with map `a`, which was the EmptyFixedArray root, which caused a
    segfault, since this is in read-only space.

The fix is to add a compilation dependency for map slack-tracking when
deciding to extend (or not) the property backing store of an object.
At the end of compilation, if the construction_counter of the Map is 0
and the one of the MapRef is non-0, then slack tracking finished
during compilation, and we discard the optimized code.

While fixing this, I also found out that UnusedPropertyFields and
construction_counter were sometimes incoherent in the background,
because CSA was updating construction_counter without taking the
map_updater_access mutex (which means that when construction_counter
was 0 in the background, it wasn't always safe to look at
UnusedPropertyFields, since it could contain the old value).
Similarly, MapRef::IsInobjectSlackTrackingInProgress was looking at
the Map rather than the cached value for construction_counter, which
means that it could also be out of sync with UnusedPropertyFields.

Bug: chromium:1444366
(cherry picked from commit 7effdbf)

Change-Id: I6005ccf87b3bffdcf5a21c49afe4a5abc0c05789
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4667386
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
Commit-Queue: Darius Mercadier <dmercadier@chromium.org>
Cr-Commit-Position: refs/branch-heads/11.5@{v8#29}
Cr-Branched-From: 0c4044b-refs/heads/11.5.150@{#1}
Cr-Branched-From: b71d303-refs/heads/main@{#87781}
gcjenkinson pushed a commit that referenced this pull request May 2, 2024
Change-Id: If61e9a03f5ebf1b96fb5c381119498d1ac55a027
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4667368
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/11.5@{v8#30}
Cr-Branched-From: 0c4044b-refs/heads/11.5.150@{#1}
Cr-Branched-From: b71d303-refs/heads/main@{#87781}
gcjenkinson pushed a commit that referenced this pull request May 2, 2024
(cherry picked from commit 95eda07)

Change-Id: I2000f5b008a473d50a8fbb181d96668ae7b6826f
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4660572
Commit-Queue: Darius Mercadier <dmercadier@chromium.org>
Auto-Submit: Tobias Tebbi <tebbi@chromium.org>
Reviewed-by: Darius Mercadier <dmercadier@chromium.org>
Cr-Commit-Position: refs/branch-heads/11.5@{v8#31}
Cr-Branched-From: 0c4044b-refs/heads/11.5.150@{#1}
Cr-Branched-From: b71d303-refs/heads/main@{#87781}
gcjenkinson pushed a commit that referenced this pull request May 2, 2024
Change-Id: Ie38c932a6fe3c453871fdf6d759fd583eb839f8d
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4667372
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/11.5@{v8#32}
Cr-Branched-From: 0c4044b-refs/heads/11.5.150@{#1}
Cr-Branched-From: b71d303-refs/heads/main@{#87781}
dstolfa added a commit that referenced this pull request Aug 23, 2024
Similar to cfa1aba, sometimes v8's
codegen modifies sentries. In order to preserve them, we need to
generate an instruction sequence as follows:

  adr c1, 0
  orr x0, x0, #1
  scvalue c1, c1, x0
  seal c0, c1, rb

However, we also need to check if we are actually operating on a sentry,
because we might be working with JITted code that simply has an RX
capability. We don't produce sentries for those yet, so we either derive
from the PCC, or we don't derive anything.

This commit further adds various Morello instructions such as gclen,
scbndse, gcseal, seal and build and re-formats some existing parts of
the code. It also adds a new abort reason for the codegen to use in case
of unexpected sealed capabilities and makes use of it in the Mov
immediate instruction, which should help debugging.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant