Remove C{To,From}Ptr #73
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arichardson
reviewed
Jun 1, 2023
There was a problem hiding this comment.
I'm very happy to remove these instructions - however, LLVM will still emit them so I think we should wait before merging this change until LLVM can lower cap<->pointer conversions without these instructions. I have some local changes to LLVM that I'll try to submit shortly.
|
Yep, no hurry! |
|
I think we can merge this once CTSRD-CHERI/llvm-project#708 has landed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following discussion yesterday, remove these instructions. If people are happy, I'll go ahead and make the changes to the pose spec.