Skip to content

Commit

Permalink
Revert to f126dbe
Browse files Browse the repository at this point in the history
  • Loading branch information
marnovandermaas committed Nov 1, 2021
1 parent 0101550 commit c36b437
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 7 deletions.
6 changes: 1 addition & 5 deletions .github/workflows/compile.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,7 @@ jobs:
- name: Init opam
run: opam init --disable-sandboxing -y
- name: Install sail
run: |
git clone https://github.com/rems-project/sail.git
cd sail
opam pin add sail .
cd ..
run: opam install -y sail
- name: Check out repository code
uses: actions/checkout@HEAD
with:
Expand Down
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ ifneq (,$(SAILCOV))
ALL_BRANCHES = generated_definitions/c/all_branches
C_FLAGS += -DSAILCOV
SAIL_FLAGS += -c_coverage $(ALL_BRANCHES) -c_include sail_coverage.h
C_LIBS += $(SAIL_LIB_DIR)/coverage/libsail_coverage.a -lm -lpthread -ldl
C_LIBS += $(SAIL_LIB_DIR)/coverage/libsail_coverage.a -lpthread -ldl
endif

# The C simulator can be built to be linked against Spike for tandem-verification.
Expand Down
2 changes: 1 addition & 1 deletion sail-riscv

3 comments on commit c36b437

@jrtc27
Copy link
Member

@jrtc27 jrtc27 commented on c36b437 Nov 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File a pull request next time so CI runs before it ends up in master?

@marnovandermaas
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, the fix was more difficult than I initially anticipated. I've made a branch to work out the issues without polluting the main branch.

@jrtc27
Copy link
Member

@jrtc27 jrtc27 commented on c36b437 Nov 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#18 contains at least some of what you'll need, don't know if there's more

Please sign in to comment.